Coder Social home page Coder Social logo

Comments (3)

tapocol avatar tapocol commented on July 24, 2024 1

It seems like these tags are incompatible. as FormatErrorFn in the handler package seems to just get nil for the error from the graphql/gqlerrors package.

Oh, this looks like it is nil because now instead of the context of gqlerrors.FormattedError in the argument, that argument is stripped to the result of OriginalError() call to the FormattedError. Which in the case of my testing originalError on FormattedError was not being set.

from handler.

chris-ramon avatar chris-ramon commented on July 24, 2024

Hi @tapocol! thanks for the friendly reminder 👍 , I've just released graphql-go/handler v0.2.3 which targets latest graphql-go/graphql v0.7.7

from handler.

tapocol avatar tapocol commented on July 24, 2024

It looks like there is a mixup. https://github.com/graphql-go/graphql/commits/v0.7.7 does not include a commit for "consolidates original error to allow custom format error". Yet, handler tag https://github.com/graphql-go/handler/commits/v0.2.3 does include a commit for "handler: consolidate FormatErrorFn"

It seems like these tags are incompatible. as FormatErrorFn in the handler package seems to just get nil for the error from the graphql/gqlerrors package.

from handler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.