Coder Social home page Coder Social logo

Comments (8)

karussell avatar karussell commented on June 16, 2024

This will be fixed in the next days via adding the header:
Access-Control-Expose-Headers: X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-RateLimit-Credits

from directions-api.

opoto avatar opoto commented on June 16, 2024

Hi
Had this fix been released?
Thanks

from directions-api.

karussell avatar karussell commented on June 16, 2024

Hmmh, it should have been but does not look so. Will investigate.

from directions-api.

karussell avatar karussell commented on June 16, 2024

We set Access-Control-Expose-Headers only if the http method is "options", which should make it working on all recent browsers. If you had a problem with this, would you mind to let me know your browser version etc?

from directions-api.

opoto avatar opoto commented on June 16, 2024

Tested on latest Chrome and Mozilla on Windows, Ubuntu and Android and it does not work.
Why only set the header on OPTIONS? It should be on GET too.
Whether it works or not can be easily tested with one click (replace MY-KEY with valid key):
http://www.test-cors.org/#?client_method=GET&client_credentials=false&server_url=https%3A%2F%2Fgraphhopper.com%2Fapi%2F1%2Froute%3Fpoint%3D43.2301414%2C5.4369798%26point%3D43.23088361474902%2C5.43874740600586%26point%3D43.23150897353908%2C5.442867279052735%26point%3D43.23113375903503%2C5.444755554199219%26instructions%3Dtrue%26type%3Djson%26key%3DMY-KEY%26vehicle%3Dfoot&server_enable=true&server_status=200&server_credentials=false&server_tabs=remote

from directions-api.

karussell avatar karussell commented on June 16, 2024

Strange, a customer requested this and tested this with the same website and it worked for them. Will have to read more what the correct procedure would be.

from directions-api.

karussell avatar karussell commented on June 16, 2024

Sorry, was confusing Access-Control-Allow-Headers (only for preflight query) and Access-Control-Expose-Headers. Will fix

from directions-api.

karussell avatar karussell commented on June 16, 2024

Fixed

from directions-api.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.