Coder Social home page Coder Social logo

ENUM is being quirky about graphql-go HOT 3 CLOSED

graph-gophers avatar graph-gophers commented on August 23, 2024
ENUM is being quirky

from graphql-go.

Comments (3)

EmperorEarth avatar EmperorEarth commented on August 23, 2024

After talking with you and playing with your port a bit more, @neelance, I have an idea.

Without fully understanding your code, I think you are trying to enforce two rules:

  • In your schema parser/packer, if an enum is nullable, then its resolver must have a pointer return, with a nil pointer translating to null value
  • In your executor, if a type is custom, then it needs a non-nullable type to unmarshal

Combined with a third fact, ENUMs aren't a type in Go, means that nullable ENUMs are trapped between your rules.

My guess might be way off base or I might have explained this poorly. But perhaps it's a place to start.

(I'm assuming something like wrapping your unmarshaller with an adapter that can handle pointers and especially handle nil pointers?)

from graphql-go.

neelance avatar neelance commented on August 23, 2024

Hey, thanks for reporting this. Could you please try again with the latest master? I did some changes, but I'm not sure if it fully resolves this.

from graphql-go.

EmperorEarth avatar EmperorEarth commented on August 23, 2024

Can confirm, this has been fixed, thanks so much

from graphql-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.