TS to OpenAPI does not produce descriptions from the comments about typeconv

[github-actions]

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[grantila]

Great feedback, I'll look into configuring it by command line arguments. Defaulting to only top-level types probably makes sense.

[grantila]

Not sure if this has been a bug, but in the latest version this does work, however these will be saved into title rather than description.

I made a unit test out of this and god the following result:

    components:
      schemas:
        Point:
          properties:
            x:
              title: The distance from the left in mm
              type: number
            'y':
              title: The distance from the top in mm
              type: number
          required:
            - x
            - 'y'
          additionalProperties: false
          type: object

Let me know if this is an issue.

[rattrayalex]

Yeah, sorry, title is a different thing - it really should be description. Title if anything should be the type name of the top level item, like:

/** This is useful for such and such */
type Foo = { a: number }

Becomes

title: Foo
description: This is useful for such and such
type: object
properties:
  a: 
    type: number

You can take a look at how stripe-node's TS types are printed from their openapi spec for a real world example

[grantila]

OpenAPI forwards the title field straight from JSON Schema, which is a bit unclear about this: http://json-schema.org/draft/2020-12/json-schema-validation.html#rfc.section.9.1 but the "A title will preferably be short" means you're probably right.

I'll try to fix this throughout the core-types packages (it affects quite a few packages), it does make sense, thanks for enlightening me!

[rattrayalex]

Awesome, thanks so much!

[rattrayalex]

Amazing!! That was quick.

FWIW I would actually recommend against adding titles like Point.x, which I see in the spec, but the addition of the title for things like Point is definitely awesome. I don't think it can really hurt per se to add Point.x, so I don't think you should feel obligated to remove it (though now would be the easiest time, before anyone starts relying on it) but it definitely seems nonstandard/redundant to my OpenAPI eyes.

[jguerinet]

Hi @grantila, did you ever configure the removal of the title via command line arguments by any chance? I find it fairly redundant as well and would like to remove it but I don't seem to see an option to (or maybe I'm just not looking in the right spot).