Automatically detect URLs and make them clickable in source publication field about gramps-web

[DavidMStraub]

Nevermind, found a way 😉

[DavidMStraub]

Good idea. We already do this in notes:

https://github.com/gramps-project/gramps-web/blob/main/src/components/GrampsjsNoteContent.js#L4-L12

So, should be straightforward to generalize.

[TheMihle]

Good idea. We already do this in notes:

https://github.com/gramps-project/gramps-web/blob/main/src/components/GrampsjsNoteContent.js#L4-L12

So, should be straightforward to generalize.

I did notice its already done in Notes.

If you end up doing it for Gramps Web, is it easy to include in for example Narrative Web and Dynamic Web report too? Like could it maybe just be copy pasted in to those too?
I ask mostly because I am curious.

[DavidMStraub]

I realized this is a bit trickier than anticipated.

For notes, we're injecting the anchor tags into the note HTML after rendering it. But this is only safe because note content is sanitized by the backend.

For the other elements, they may contain unsafe HTML code in principle - this is not an issue because Lit will not render it as HTML. But if would use the same approach as in notes, we would have to render the raw (unsanitized) string which could contain malitious code.

So this needs a bit more thought to implement in a safe way; either by sanitizing those elements in the backend or finding a way to use lit-html to replace the URLs.

[DavidMStraub]

Note complete - citation page & attribute values done, source publication missing.