Comments (5)
Nevermind, found a way 😉
from gramps-web.
Good idea. We already do this in notes:
https://github.com/gramps-project/gramps-web/blob/main/src/components/GrampsjsNoteContent.js#L4-L12
So, should be straightforward to generalize.
from gramps-web.
Good idea. We already do this in notes:
https://github.com/gramps-project/gramps-web/blob/main/src/components/GrampsjsNoteContent.js#L4-L12
So, should be straightforward to generalize.
I did notice its already done in Notes.
If you end up doing it for Gramps Web, is it easy to include in for example Narrative Web and Dynamic Web report too? Like could it maybe just be copy pasted in to those too?
I ask mostly because I am curious.
from gramps-web.
I realized this is a bit trickier than anticipated.
For notes, we're injecting the anchor tags into the note HTML after rendering it. But this is only safe because note content is sanitized by the backend.
For the other elements, they may contain unsafe HTML code in principle - this is not an issue because Lit will not render it as HTML. But if would use the same approach as in notes, we would have to render the raw (unsanitized) string which could contain malitious code.
So this needs a bit more thought to implement in a safe way; either by sanitizing those elements in the backend or finding a way to use lit-html to replace the URLs.
from gramps-web.
Note complete - citation page & attribute values done, source publication missing.
from gramps-web.
Related Issues (20)
- Please add support for custom name display formats
- Please provide media upload error details HOT 3
- [Feature request] Run docker as non root user HOT 1
- SMTP "Error while trying to send e-mail." HOT 5
- Allow external user authentication via OIDC or SAML HOT 1
- Picture for each node in RelationshipsTree HOT 2
- Fan chart not displayed in Safari HOT 4
- On a fresh install, with or without a config file, I get the error: FileNotFoundError: [Errno 2] No such file or directory HOT 1
- [BUG] Unable to run docker in a multi-tree setup HOT 9
- Qualify redis image name HOT 1
- OpenHistoricalMap map should default to more relevant date for places and people
- Feature Request: Remove OpenCV and LibLLVM from Docker Image HOT 1
- The "new attribute" modal for editing a person is too small HOT 4
- Allow renaming repositories HOT 7
- Gramps XML export fails with 'can only concatenate str (not "NoneType") to str HOT 6
- "Encountered errors during upload" but no further information HOT 1
- Place type cannot be edited if non-existent HOT 3
- Surnames in family children list HOT 2
- Add forms are clearing weirdly on gramps web HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gramps-web.