Coder Social home page Coder Social logo

Comments (11)

sletz avatar sletz commented on September 27, 2024

Thanks, can you prepare a PR for that ?

from faust.

sletz avatar sletz commented on September 27, 2024

BTW, what happens when they are more the 8 channels in the Faust DSP code ? Should we stay with discreteChannels() there ?

from faust.

skraninger avatar skraninger commented on September 27, 2024

cannonicalChannelSet(n) actually returns discreteChannels(n) when n > 8. I am going to look into this some more and ask some additional questions in the JUCE forums. There were some forum posts on Steinbergs forum about VST3 channel limitations and how they caused some issues with multi-channel systems (asking for changes). I don't understand why discreteChannels() should raise an error, it seems like it should function properly.

from faust.

sletz avatar sletz commented on September 27, 2024

OK, great, so then can you prepare a PR? This would be of great help ! Thanks.

from faust.

skraninger avatar skraninger commented on September 27, 2024

Q: Is there a simple function like canonicalChannelSet(n) that will return a valid VST3 channel layout up to n=64? I looked at the functions available, and it was not clear what to use?

A: No, such a function can’t really be implemented. VST3 only defines 61 different speaker types, so it’s not possible to define layouts with 62+ channels. Due to the way VST3 speaker layouts work, some channel layouts with fewer than 61 channels would have conflicting semantics and should be avoided, e.g. a channel layout with 37 channels would have to include both ambisonic and non-ambisonic speaker types, and most hosts won’t know how to work with such layouts.
If you need discrete channel layouts and/or arbitrary channel counts in a VST3 plugin, I’d recommend contacting Steinberg and asking whether they’d consider adding this to the VST3 specification.

ALSO

I have never prepared a PR. I am happy to assist, but need a bit of direction as to how to do a PR for this project.
Thanks

from faust.

sletz avatar sletz commented on September 27, 2024

Do you have a Faust fork when your code is implemented ?

from faust.

skraninger avatar skraninger commented on September 27, 2024

I pulled from Git Current Branch master-dev and made the changes. I did not create a fork yet.
When I select the option to create a fork, there is an option to contribute to the grame-faust repository. At this point I cancelled. Should I contiune? Any specific intructions?

from faust.

sletz avatar sletz commented on September 27, 2024

Yes just try to "contribute to the grame-faust ",and see what happens (hopefully a Pull Request will be created and so on...)

from faust.

sletz avatar sletz commented on September 27, 2024

Where is your updated master-dev branch ?

from faust.

skraninger avatar skraninger commented on September 27, 2024

from faust.

sletz avatar sletz commented on September 27, 2024

Thanks, done in fb04f81

from faust.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.