Coder Social home page Coder Social logo

Comments (2)

pablochacin avatar pablochacin commented on June 12, 2024 1

Unit tests did not catch this mistake because the mocked HTTP client never exercises this request. This is the kind of subtlety that integration tests are good at (re. #183)
I am not sure why e2e tests did not catch this.

We already have #183 for this discussion about integration tests, but for me, the solution to "e2e test did not catch it" is not to create integration tests because the e2e tests use an actual HTTP server, so I don't see what value it would add.

I think the problem is much simpler: we in the e2e tests are not checking that we don't introduce errors. We are just checking if we get the error we ask for.

So, we don't need to add more tests, just one test case to the existing e2e tests. For example, with errorRate: 0 (do not inject errors) and checking if we get a 200. I suggest we do it in the context of fixing this issue.

from xk6-disruptor.

roobre avatar roobre commented on June 12, 2024

It seems like this was caused by a dumb typo: upstreamReq was cloned and its RequestURI cleared, but req was passed instead of upstreamReq 🤦🏻‍♀️

image

Unit tests did not catch this mistake because the mocked HTTP client never exercises this request. This is the kind of subtlety that integration tests are good at (re. #183)

I am not sure why e2e tests did not catch this.

from xk6-disruptor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.