Coder Social home page Coder Social logo

Comments (6)

Duologic avatar Duologic commented on June 6, 2024

Perhaps you can call it twice, once with CRDs and controller enabled and explicitly gateway disabled. Second the other way around.

from tanka.

zarelit avatar zarelit commented on June 6, 2024

The problem lies in the fact that the kong chart template emits the very same CRDs regardless of the values.
So the possible workarounds are:

Reimplement the umbrella chart in jsonnet

  • instead of templating kong/ingress we template kong/kong twice, one for controller and one for ingress
  • includeCRDs = true only for one component

Pros: it's still declarative and you can tk apply once
Cons: if the umbrella chart changes upstream, the workaround does not work anymore

Template the umbrella chart twice with different values

  • we template kong/ingress twice, with values for controller and for ingress
  • includeCRDs = true only for one call of helm.template

Pros: it's still declarative and you can tk apply once, compatible with upstream chart as long as the values don't change
Cons: leaves user wondering why we are templating the same thing twice

Template the umbrella chart once but apply twice

  • kong/ingress templated only once in the jsonnet code
  • change values and apply twice
  • includeCRDs= true only in one apply call

Pros: committed code looks like we're just applying an helm chart
Cons: not declarative, what values have been applied before needs to be documented

from tanka.

zarelit avatar zarelit commented on June 6, 2024

Can we have a relaxed mode for duplicated resources for niche cases like this one?

from tanka.

Duologic avatar Duologic commented on June 6, 2024

I was able to get it execute this way:

local tanka = import 'github.com/grafana/jsonnet-libs/tanka-util/main.libsonnet';
local helm = tanka.helm.new(std.thisFile);
{
  _config:: {
    ns: 'kong',
  },
  kong_ingress_controller: helm.template('kong', './charts/ingress/', {
    namespace: $._config.ns,
    includeCRDs: true,
    values+: {
      gateway+: { enabled: false },
    },
  }),
  kong_ingress_gateway: helm.template('kong', './charts/ingress/', {
    namespace: $._config.ns,
    includeCRDs: false,
    values+: {
      controller+: { enabled: false },
    },
  }),
  kong_namespace: {
    apiVersion: 'v1',
    kind: 'Namespace',
    metadata: {
      name: $._config.ns,
    },
  },
}

from tanka.

zarelit avatar zarelit commented on June 6, 2024

@Duologic Thank you for your help, that's the mid option described above and it works.
I still feel it is a workaround and would like to see a way to tell Tanka "yes there are duplicated resources, deal with it".
So I'm going to close this issue about kong. Let me know if I should open another one for a feature request "relaxed duplicated resources". If you feel this is not needed or in general not in the scope of tanka, I won't ask for it.

from tanka.

Duologic avatar Duologic commented on June 6, 2024

The duplication protection prevents unintended ambiguity. Imagine you have a Deployment defined twice, but one of them has replicas: 1 and the other replicas: 10, which value should Tanka choose? This kind of ambiguity leads to mistakes down the line and making it harder to debug.

Or with other words, the Helm chart should probably not spit out the CRDs twice.

from tanka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.