Coder Social home page Coder Social logo

Make project.sync() a public API about gradle HOT 11 CLOSED

gradle avatar gradle commented on July 28, 2024
Make project.sync() a public API

from gradle.

Comments (11)

big-guy avatar big-guy commented on July 28, 2024 1

Sure, please make sure you take a look at our contributing guidelines.

from gradle.

big-guy avatar big-guy commented on July 28, 2024 1

Thanks @hotchemi. I'll take a look.

Yes, those are both areas that we need to improve. You can leave those alone for this story. We have a general problem with the Copy-like tasks having under specified inputs like that.

from gradle.

eriwen avatar eriwen commented on July 28, 2024

@big-guy We're booked for 3.3, so I think this should go in the next release after that unless it's very easy. Any thoughts? Is this easy enough we could ask for outside contribution?

from gradle.

big-guy avatar big-guy commented on July 28, 2024

It's pretty easy.

We need to add the sync method with the signature WorkResult sync(Action<? super CopySpec> action); and documentation to subprojects/core/src/main/java/org/gradle/api/Project.java

We need to add the method to the DSL here: subprojects/docs/src/docs/dsl/org.gradle.api.Project.xml

Make sure we have decent test coverage, something like we do in CopyTaskIntegrationSpec and CopySpecIntegrationSpec in SyncTaskIntegrationTest or a new class.

from gradle.

big-guy avatar big-guy commented on July 28, 2024

Note that we do not want a Closure version of this method.

from gradle.

ajoberstar avatar ajoberstar commented on July 28, 2024

👍

from gradle.

oconnelc avatar oconnelc commented on July 28, 2024

I maybe able to take a look at it this weekend.

from gradle.

hotchemi avatar hotchemi commented on July 28, 2024

Can I grab the issue?

from gradle.

hotchemi avatar hotchemi commented on July 28, 2024

Addressed on #1137!
Btw, I found two NotYetImplemented annotations in integtests file. Would they be another story to enhance?

from gradle.

hotchemi avatar hotchemi commented on July 28, 2024

@big-guy Thank you for your response. Okay, so let me try to fix them when I can get a time to look into if it's okay.

from gradle.

henryptung avatar henryptung commented on July 28, 2024

@big-guy Why no closure version?

from gradle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.