Comments (6)
from gpsbabel.
Thanks, please find the updated patch with the requested changes here
https://gist.github.com/frief/fc7fffb0b855d94df5ce645a5db4374b
The .fit file includes laps and was recorded with heartrate, power (with cadence), speed and Shimano Di2 gear shifting data. (Just drop a note if not ok)
from gpsbabel.
I vote for this bug since more and more devices generates FIT 2.0.
from gpsbabel.
Hi,
I have some code ready to support FIT 2.0. At least in the way that it read all the data we already get for FIT version 1 files. For the tests I still have to record a track again. The one I have, started at my front door. I want to avoid this. Then I have to do a last code review by myself and then I can do the pull request. This week I am very short of time. But I hope I get the things done before the weekend.
In some way I understand your reasoning with the warning. If the old code can handle the data (because it does not use "special things" from version 2.0) you get a result. If it cannot handle the data while converting it, it is the same as it give you the error that it does not support version 2.0.
But if it gives you a warning you also have the possibility that it will write wrong data. Who knows this exactly, even if I do not expect it in practice. And having code that write wrong data is something one wants to avoid.
For me e.g. the old code throws an error while converting data because the Wahoo Element Bolt uses so called developer fields which are not handled in the current implementation.
I hope this helps a little bit.
from gpsbabel.
@tormet It's great you have a patch and thanks for the analysis that developer fields may cause a crash.
You are generally right about dangers reading unsupported version. I think the idea from @robertlipe solves it - some input (command line) parameter like "force", "ignore version", etc would solve it. Then it would be up to the user to take the risk of unsupported version or not. It may be implemented even with your patch. Who know, maybe tomorrow the new version of FIT will be released ...
from gpsbabel.
@xmedeko I agree concerning the idea of a command line parameter like "force", "ignore version" ....
If it is only a flag for the garmin_fit format the implementation seems to be easy. If it should be a global flag for "everything" one has to figure out where it should have a meaning.
from gpsbabel.
Related Issues (20)
- sub-second timestamps in OSM XMLs HOT 8
- strftime/strptime specifiers -> QDate/QTime/QDateTime specifiers? HOT 2
- Converting encoding of waypoints names HOT 55
- Say "No valid input type specified before input filename." HOT 1
- trackfilter: Don't require unused time values for each trackpoint
- filter_track.html corrections HOT 2
- ‘kVersionDate’ was not declared in this scope HOT 2
- igc compile warning HOT 2
- garmin int->float->int fidelity HOT 1
- trackfilter pack handling of segments HOT 5
- :error:fetch Failed to fetch curl-ca-bundle: The requested URL returned error: 404 Not Found HOT 6
- truncation can compromise the meaning of help strings HOT 2
- garmin_fit does not support course_point types well HOT 4
- www.gpsbabel.org doesn't contain a link to github page HOT 3
- garminextensions option (-o gpx,...) removes <speed> from output file HOT 2
- 1.9.0 GUI pop up "Invalid return data at line 1 ..." HOT 3
- gpx writer may violate schema HOT 1
- gpx writer can violate schema when extensions exist, gpx read and write versions differ, and passthrough is used. HOT 1
- gpx.h GEOTAG searches for elements that imply a gpx schema violation HOT 9
- C++20? HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gpsbabel.