Coder Social home page Coder Social logo

Bower Support about react-day-picker HOT 12 CLOSED

gpbl avatar gpbl commented on May 24, 2024
Bower Support

from react-day-picker.

Comments (12)

gpbl avatar gpbl commented on May 24, 2024

Yes thanks! I have no idea how does bower work, but sure it would be nice to support it.

from react-day-picker.

gpbl avatar gpbl commented on May 24, 2024

Woah I've made some crazy things with bower register, npm publish etc... 👯 now it should work everything as version 1.1.3.

@jkillian Could you please test if it actually works with bower and eventually close the issue? I don't get why it doesn't appear in their search...

from react-day-picker.

jkillian avatar jkillian commented on May 24, 2024

@gpbl I see it in the search now - probably just a caching issue! I'll try it out now

from react-day-picker.

jkillian avatar jkillian commented on May 24, 2024

Working like a charm in my project 👍

from react-day-picker.

jkillian avatar jkillian commented on May 24, 2024

Right now we're only exposing the DayPicker React class as a global variable named DayPicker. Do you think instead we should export an object called DayPicker and then it could have the following fields:

  • DayPicker
  • LocalUtils
  • MomentLocaleUtils
  • Helpers
  • DateUtils

or something similar to that?

from react-day-picker.

gpbl avatar gpbl commented on May 24, 2024

I was wondering as well... we should however export only the "official" API.

I don't know what are the common practices for a bower component, but I imagine:

DayPicker
DayPicker.localeUtils
DayPicker.dateUtils
DayPicker.momentLocaleUtils

I think we can add some static properties to DayPicker when exporting it, so that the component is actually <DayPicker /> and not <DayPicker.DayPicker> or, as I thought at first, <DayPicker.Component />.

(I'm not so happy for this *Utils convention , how would you call them?)

from react-day-picker.

jkillian avatar jkillian commented on May 24, 2024

Actually, I think the *Utils names are pretty clear, they make sense to me. Do you want to go ahead and do this or want me to take a shot at it?

from react-day-picker.

gpbl avatar gpbl commented on May 24, 2024

I have no interest in bower so I'd really appreciate a PR 🖖. (pay attention to that momentLocaleUtils, because it requires moment but I won't put moment as dependency. Maybe you need some "ignore" setting in the webpack config).

Deep thanks for your support, JKillian!

from react-day-picker.

jkillian avatar jkillian commented on May 24, 2024

I think PR #93 should take care of things here. Let me know once you release and I'll test it out!

from react-day-picker.

gpbl avatar gpbl commented on May 24, 2024

@jkillian I've published 1.1.4 – it should work! Does it? 👀

from react-day-picker.

jkillian avatar jkillian commented on May 24, 2024

Working well for me! 👍

from react-day-picker.

gpbl avatar gpbl commented on May 24, 2024

excellent! thanks for the help!

from react-day-picker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.