Lint issues in dockerfile_exec_\*.sh about govready-q

[davidpofo]

@wesley-dean-flexion The image uploaded to docker hub is currently 8 months old and doesn't represent the current state of govready. In the installing guide you can build a container of your own if you desire. Efforts will be made to keep our hub image to be updated after some upcoming key releases.

[wesley-dean-flexion]

The lint issues are present in the main branch of the repository on GitHub pulled today; that the image on DockerHub fails is not the issue.

[its-a-lisa-at-work]

@davidpofo @gregelin do ya'll have an estimate on when the key releases when will be out?

[gregelin]

@wesley-dean-flexion @its-a-lisa-at-work We will work on fixing this week. I'm just reading through this issue now and need to spend some time looking at what's going on with the linting.

As you probably saw in our docs, we replaced the single container approach with a more robust container stack. This was a bit of debate internally of having a pre-built container vs building a stack. The reason the stack won out was that in more than 50% of the time, the container deployed ends up being custom to the deployment. Either the organization wants to build on their base image or there is some other customization. We can certainly help creating a deployment that works for you so you don't have fight any gotchas in our code alone.

For reference here is our new deployment information.

• https://github.com/GovReady/govready-deployments - for simple/test deployments
• https://github.com/GovReady/govready-q/tree/main/dev_env - for dev deployments and doing development

(We didn't update the Docker Hub content in a timely fashion after we made this change. At the end of last week we updated Docker Hub to mark it deprecated.)

(Note: This reply has been updated because the original version unintentionally came off as snarky.)

[davidpofo]

@wesley-dean-flexion @its-a-lisa-at-work I made a branch & PR which addresses all but one warning from shellcheck SC2153: Possible misspelling: EMAIL_PORT may not be assigned, but EMAIL_HOST is. EMAIL_PORT is properly assigned it is just too close to EMAIL_HOST spelling. Is this acceptable?

[gregelin]

@wesley-dean-flexion, here is current status of this ticket:

1. line 104: [: too many arguments / if [ $DB_BEFORE_090 = "True" ]
   status: In progress
   details: Will be removing outdated check related to long database migration from 0.8.6 to 0.9.0

2. Lint errors on dockerfile_gunicorn_exec.sh
   status: fixed
   details: See #1670 and above issue

3. (implicit) complexity of gunicorn vs uwsgi
   status: to be fixed
   details: We only use Gunicorn. Need to refactor to remove legacy code. Will create a new ticket before closing this ticket

4. (implicit) Documentation
   status: fixing
   details: Cleaning up information in deployment/docker/README.md

5. (implicit) Getting a Docker container for GovReady-Q
   status: to be fixed
   details: Will create documentation and maybe example to make it easier to build stand alone GovReady-Q container.