Coder Social home page Coder Social logo

Comments (36)

fcevado avatar fcevado commented on April 27, 2024 6

I don't know if it should be discussed here, at the @BrainMaestro repo, or at the gitter. But shouldn't it be using the phoenix 1.3 structure? I know it's not released yet, but it already has rc-1 and it's possible to create a project with the new structure. Since it's a project to serve as an example for devs, I think it should be built with the new structure.
The first topic in this talk by Chris Mccord(the creator of Phoenix) is this organization change:
https://www.youtube.com/watch?v=tMO28ar0lW8

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024 5

I think 1.3 is a good choice too. Will update it.

from realworld.

lbighetti avatar lbighetti commented on April 27, 2024 5

@BrainMaestro In this case, please transfer the repo to me, I'm happy to take over.
And +1 appreciate your efforts getting this off the ground.

from realworld.

jamesbrewerdev avatar jamesbrewerdev commented on April 27, 2024 4

Hey, yall!

I think this conversation would be better had at BrainMaestro/elixir-phoenix-realworld. As a rule of thumb, implementation-specific talks are a good candidate for being in the implementation repo.

CC @EricSimons Thoughts?
CC @fcevado Because you said you weren't sure. 😄

from realworld.

lbighetti avatar lbighetti commented on April 27, 2024 3

Hi @EricSimons,

We have just completed implementing the specs !
Can you move us to peer review?

I'm working on deploying this to heroku so we can use frontends with it.

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024 2

Thanks! I'll do that soon.

from realworld.

agustif avatar agustif commented on April 27, 2024 2

@BrainMaestro I would like to help on elixir/phoenix counterpart.

It seems like a really good exercise to make to learn to load associations and stuff...

Lemme know if you want to team-up or somethin!

from realworld.

sotojuan avatar sotojuan commented on April 27, 2024 2

@BrainMaestro happy to join and contribute. Will check things out this week :-)

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024 2

I added a list of all the tasks to a github project here

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024 1

@agustif sure that sounds great! Just give me some time to set it up.

from realworld.

agustif avatar agustif commented on April 27, 2024 1

Sure np! if you think that's ok just mention me on what you could use some help on!

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024 1

@sotojuan I already created a repo here https://github.com/BrainMaestro/elixir-phoenix-realworld. Sorry for not linking it earlier.

I think Phoenix the latest stable phoenix is a good idea. I'll add the starter files today. Also thanks for wanting to contribute. This project will pick up steam soon. Sorry for slowing everyone down.

from realworld.

sotojuan avatar sotojuan commented on April 27, 2024 1

Thanks @BrainMaestro! Will have a PR or something up soon :-)

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024 1

Hey @lbighetti. That's great. I'll do that right now. Thanks for taking over.

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024 1

@lbighetti awesome work!! 👏 I will move ya to RFC first thing tomorrow morning :)

from realworld.

lbighetti avatar lbighetti commented on April 27, 2024 1

Ping @EricSimons 😃

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024 1

@lbighetti done!! So sorry about my delay on this, the past few weeks have been nuts 😅

To everyone who helped put this together: thank you so much, this is seriously incredible work. 👏 I've just created the new repo (https://github.com/gothinkster/elixir-phoenix-realworld-example-app) and listed it on the main readme! Feel free to push any remaining updates for the repo's readme/etc over at the new repo 👍

Again, amazing works and congrats!!

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

Awesome! Wanna fork our starter kit and post the link in this issue so others can watch/fork?

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

@BrainMaestro whenever you spin up the repo, feel free to swap out the default starter logo with this one I just made:

elixir-logo

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

Just set up the Gitter chatroom for this! Lets do our collaborator coordination in there 👍

cc/ @BrainMaestro @agustif

from realworld.

sotojuan avatar sotojuan commented on April 27, 2024

So I forked the starter kit here (https://github.com/sotojuan/realworld-starter-kit) as per Eric's instructions. Happy to work somewhere else though since it was your idea @BrainMaestro.

Before I do anything... what are we using? Raw Plug? Phoenix (1.2 or 1.3 beta?)? Feel free to answer here or in Gitter.

from realworld.

agustif avatar agustif commented on April 27, 2024

+1 on 1.3 but doesnt matter starting on 1.2, we could document changes and update the repo and that would help making old docs/tutos not as much obsolete maybe

But id do it in 1.3 too, I was just waiting to see what @smpallen does on coherence

from realworld.

fcevado avatar fcevado commented on April 27, 2024

But id do it in 1.3 too, I was just waiting to see what @smpallen does on coherence

I wouldn't recomend coherence at all, it's built with comeonin and probably uses bcrypt. It looks like it's made to work with devise.
I'd rather built it from scratch(given the modular nature of Elixir/Phoenix, it's not a complex thing) using argon2 for hashing.
Just for reference:
https://password-hashing.net/

from realworld.

agustif avatar agustif commented on April 27, 2024

I am not advocating for coherence for this project, but I'm following along the updates of some libraries I want to use in a personal project and everyone seems to be scrambling to do the 1.3 updates, that was my point, just waiting to see what others do and then proceed.

Since we're doing an API only backend Im guessing we will use guardian and maybe guardian_db to store passwords in db.

I've recently used Gatling for deployment to ubuntu VPS and was happy to not have to interact with nginx!

from realworld.

fcevado avatar fcevado commented on April 27, 2024

I am not advocating for coherence for this project, but I'm following along the updates of some libraries I want to use in a personal project and everyone seems to be scrambling to do the 1.3 updates, that was my point, just waiting to see what others do and then proceed.

I understood that, i just commented as a tip. 😅

Since we're doing an API only backend Im guessing we will use guardian and maybe guardian_db to store passwords in db.

Actually for this project, I think it will be implemented html and api(based on the rails implementtation that has both).
@EricSimons is that correct?

I've recently used Gatling for deployment to ubuntu VPS and was happy to not have to interact with nginx!

An Elixir/Phoenix project? I think cowboy is more than enough as a server 😛 ...

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

Nope, this is strictly API requests only - the Rails codebase only sends JSON via endpoints too (no HTML, etc)

from realworld.

fcevado avatar fcevado commented on April 27, 2024

I saw some views there, thought it had html... 😅

from realworld.

agustif avatar agustif commented on April 27, 2024

Exactly, at the end of the day any of the backends will match any of the clients, and we're keeping it like this in realWorld, Im guessing server rendered pages are not taken into account.

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

Yeah server rendering was intentionally left out of the spec because of how much it varies based on framework/language/etc. So def make your tech decisions based around the backend being strictly an API server 👍

from realworld.

BrainMaestro avatar BrainMaestro commented on April 27, 2024

@EricSimons I have been busy over the last few months and have been unable to work on the project, if there's someone else interested in it, I am willing to transfer the repo over to them. Thanks.

from realworld.

huyz avatar huyz commented on April 27, 2024

@BrainMaestro Understandable. Thanks for getting things started.

I'm gonna wait until someone takes over in order to hopefully contribute

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

@lbighetti @BrainMaestro lmk if there's anything I can do here to help! Should I point the issue to point at @lbighetti's repo?

from realworld.

lbighetti avatar lbighetti commented on April 27, 2024

@EricSimons I think that makes sense 👍

from realworld.

EricSimons avatar EricSimons commented on April 27, 2024

@lbighetti hows the codebase coming along for this? I can't wait to see it! Btw I updated this issue to point at your repo 👍

from realworld.

lbighetti avatar lbighetti commented on April 27, 2024

@EricSimons Thanks!
Looking forward to joining the rank of backends 🏅

from realworld.

lbighetti avatar lbighetti commented on April 27, 2024

Thank you for the kind words @EricSimons
And thanks for moving it over!
Will continue development there.
Best!

from realworld.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.