Comments (4)
Pull requests are welcome to fix possible issues.
Without looking at the code, you might be right about duplicattion. However, a little duplication can be better than added complexity to remove the little duped code. As always: it depends
from aspnetcore-realworld-example-app.
also, seems like there is code between create and edit is duplicated... This doesn't seem like a good idea.
from aspnetcore-realworld-example-app.
I'm just having a look more than anything else, I was just curious how security was being handled. I think because of how the user concerns are spread out and are quite noisy it leads to the security problem , the duplication was the hint that should of pointed to more cohesive solution to the rules. I don't think I'd ever endorse having two locations in the code where you set things like passwords.
from aspnetcore-realworld-example-app.
Cross cutting concerns can be put in MediatR pipelines if there are any.
Things are organized vertically to illustrate how functionality is usually simple before “concerns” are added in. I’ll admit things aren’t perfect nor fully audited but I see no reason for further abstraction as there aren’t more rules to implement yet.
from aspnetcore-realworld-example-app.
Related Issues (20)
- Problems with deploying HOT 1
- HTTP ERROR 404
- Database provider SQlLite hard-coded HOT 3
- Unable to delete article containing comments HOT 2
- Implement one database transaction per HTTP API call HOT 3
- CORS and pre-flight OPTIONS requests. HOT 4
- Missing app.UseAuthentication()? HOT 2
- Class vs Namespace HOT 4
- cannot use chinese for the title of article HOT 1
- Default connection string is hard-coded, only SQLite can be used. HOT 1
- can't connect to localhost:5000 HOT 1
- No License for Repo HOT 2
- Should .dockerignore include .git folder? HOT 2
- Circular references from Article HOT 3
- Wrong docker command for 'make run' in documentation node "Docker Build" HOT 1
- Adding an existing tag when editing an article causes an error
- Badly implemented GET /articles endpoint
- ASP MVC core frontend request
- are there any plans to upgrade this to .Net 6? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from aspnetcore-realworld-example-app.