Schemes() if not matching my test about mux

[rbucker]

After some analysis I was able to determine that this and several other req.URL bugs exist in go1.0.3 and is tagged to be fixed in go1.1. I will test with 1.1 when it's available and reopen if still a problem.

[kisielk]

Do you have a link to the specific bug that fixes this behaviour? It would be nice to have a test case for it at least.

[rbucker]

Here is the bug report for the empty URL.Scheme. It is reported to be repaired in Go1.1. I'm on the fence as whether or not you need a test case for this, however, the actual test cases do not actually test real behavior and that's why it was not caught sooner.

https://code.google.com/p/go/issues/detail?id=3805

[kisielk]

The reason this isn't reflected in the mux tests is because we build all our own requests. It seems the bug is mostly to do with net/http not setting some fields in the URL. I think it would help increase the quality of the tests if we actually used net/http via httptest instead of just constructing fake requests, as that's probably the most common use case.

[rbucker]

agreed. More and better tests are always welcome.