mux headers do not support regex about mux

[jmassara]

This would be really useful. See here. It would be nice to do something like this:

r.HandleFunc("/myapp", MyHandler).
    Methods("GET").
    Headers("Accept", "application/vnd.myapp-v{version:[0-9]+}+json")
http.Handle("/", r)

Or:

r.HandleFunc("/myapp", MyHandler).
    Methods("GET").
    Headers("Accept", "application/vnd.myapp-v{version:[0-9]+}+{format:json|xml}")
http.Handle("/", r)

[fdelbos]

+1

this:

r.HandleFunc("/path", MyHandler).
        Methods("POST").
        Headers("Content-Type", "application/json")

will not match a request with "Content-Type", "application/json;charset=UTF-8"

and this:

r.HandleFunc("/path", MyHandler).
        Methods("POST").
        Headers("Content-Type", "application/json;charset=UTF-8")

will not match a request with "Content-Type", "application/json"

[eastwood]

I've added regex support. An example of usage is as follows:

    r := mux.NewRouter()
    r.HandleFunc("/", RootHandler).Headers("Content-Type", "application/json.*")
    http.ListenAndServe(":8080", r)
}

Now both requests will work:

curl -X GET -H "Content-Type: application/json" localhost:8080
curl -X GET -H "Content-Type: application/json;charset=UTF-8" localhost:8080

My personal uses were for handling application/(json|text)

[bluehallu]

@eastwood isn't HeadersRegexp what should be used here?

[eastwood]

@bluehallu That's correct. Above comment is out of date. The documentation should be up to date with this, if anybody requires it

[bluehallu]

@eastwood I've tested the code and it behaves as you'd expect, but the docs are in sync with your comment above:

"...Alternatively, you can provide a regular expression and match the header as follows..."

[eastwood]

Ah I see :) Good pickup, sorry about the confusion, must of been a legacy commit. I'll clean that up right away to fix the confusion. Alternatively, you can fix the change and make a pull request, the more contributors the merrier!

[eastwood]

#125 Should fix this up for us

[bluehallu]

I wanted to make sure I wasn't misunderstanding this before doing a PR. All
fixed now so thanks :)

On Tue, 8 Sep 2015 12:34 Clinton Ryan [email protected] wrote:

#125 #125 Should fix this up for us

—
Reply to this email directly or view it on GitHub
#16 (comment).

[jmassara]

It would be nice to support capturing regex matches in mux.Vars() (see my previous comment), similiar to how the router.HandlerFunc does it.

[kisielk]

@jmassara please open a separate issue for that.