Coder Social home page Coder Social logo

Comments (5)

OliverHofkens avatar OliverHofkens commented on July 18, 2024 2

My bad, the test case was incomplete. Hopefully 0.7.2 fixes it for real! 😅

from odata-query.

OliverHofkens avatar OliverHofkens commented on July 18, 2024 1

This was definitely not intended, so thanks for reporting this and for the simple reproducing code!
I think it'd be relatively easy to add a test on this behavior, fix the regression, and add it to the documentation/type hint while we're at it. I'll have a look soon!

from odata-query.

OliverHofkens avatar OliverHofkens commented on July 18, 2024 1

I just released 0.7.1 which should fix this. Feel free to try it out!

from odata-query.

tstadel avatar tstadel commented on July 18, 2024 1

I guess something like

    clause_element: ClauseElement = query
    if isinstance(query, Query):
        # For now, we keep supporting the 1.x style of queries unofficially.
        # GITHUB-34
        clause_element = query.__clause_element__()

    model = clause_element.columns_clause_froms[0].entity_namespace

should resolve this. But I'm not an expert on SQLAlchemy internals.

from odata-query.

tstadel avatar tstadel commented on July 18, 2024

I just released 0.7.1 which should fix this. Feel free to try it out!

@OliverHofkens I tried it out, but unfortunately if I run the example code from above I get the following error when running query.all():

AttributeError: 'Select' object has no attribute 'all'

I guess that's due to returning a Select and not as previously a Query object.

from odata-query.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.