Coder Social home page Coder Social logo

Token Leak via jishaku py about jishaku HOT 1 CLOSED

gorialis avatar gorialis commented on August 27, 2024
Token Leak via jishaku py

from jishaku.

Comments (1)

Gorialis avatar Gorialis commented on August 27, 2024 1

I have written at length in the past about why the ability to display your token using Jishaku is not a bug. I cannot stop you from intentionally exposing your credentials.

No matter what I patch for, there will always be new avenue that is not covered. If I was to explicitly detect this case, then the next complaint would be that bot.http.token[::-1] is sufficient to rebuild the token - or list(bot.http.token[::-1]). Maybe '_'.join(bot.http.token)? Am I supposed to detect if your token has been put through a Caeser Shift cipher, as well?

Please read the following to get the full spiel on why I won't fix this:
#61 (comment)

The intent of the omission is to avoid mistakes. A developer might choose to evaluate _bot.http.__dict__, or something like their own _bot.config, without thinking or realizing ahead of time that this would expose their token directly. Jishaku is, through omitting the token, attempting to prevent you from doing something you did not intend to do.

A statement as direct as list(bot.http.token) cannot be a mistake. The intent of the developer is clear - and Jishaku trusts that the intent of the developer is genuine. There are way worse things you can do if you intentionally create malicious code.

All of this boils down to:

  • Do not write code that does something you do not intend to do. Computers ask no questions.
  • Do not run code from people you do not trust, and always audit code to make sure you understand what it is doing before you run it.
  • As mentioned in the MIT License, Jishaku comes 'as is', with no warranty. The code you execute with it, and the side effects of such code, are entirely the responsibility of you, the user, and you should use it only with adequate acknowledgement and understanding of this responsibility.

from jishaku.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.