Slice out of range error about gore

[TcM1911]

Nice find. I raised #11. I'll see if I can get it fixed ASAP.

[TcM1911]

@capnspacehook, this is a known issue. This caused when incorrect compiler version is detected for the binary.

github.com/goretk/gore.getLegacyTypes(0xc0000c6540, 0x56cec0, 0xc00000e040, 0xa, 0xffffffffffffffff, 0x8)
        github.com/goretk/gore/type.go:107 +0x235

is logic for parsing versions prior to 1.7. Since the data structures in these versions are very different this can happen.

When analysing the library with the library this usually happens because the markers for different versions are included in the library.... If you know the version, you can force the assumed version by for example calling file.SetGoVersion("go1.13") after opening the file.

Until a better way for determining the version, this is the current solution.

With the release 1.13, a functionality for extracting the version was added but it only works for 1.13 and later stripped binaries:

[gore]$ file testdata/gold/gold-linux-amd64-1.13
testdata/gold/gold-linux-amd64-1.13: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=YWmIDeHrc37MnKyHo53S/hGdyCvxmA0ZSwHA56vwG/cthDW6MiJGhvIw_Mk5x0/egx2QKll4Xf19HLolX0e, stripped
[gore]$ go version testdata/gold/gold-linux-amd64-1.13
testdata/gold/gold-linux-amd64-1.13: go1.13
[gore]$ file testdata/gold/gold-linux-amd64-1.12.0
testdata/gold/gold-linux-amd64-1.12.0: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=W11rzA8dxCieF64mk9rO/wmqBULPx6tMOdPbSBabM/X40xrZ4nVRHkrWOKbwZw/JpQDPeWBsrG9Rn_jzf3s, stripped
[gore]$ go version testdata/gold/gold-linux-amd64-1.12.0
testdata/gold/gold-linux-amd64-1.12.0: go version not found

[capnspacehook]

Ok that makes sense, thanks. I will try explicitly setting the Go version. I know some other binaries I tested threw a different error, I think related to the fact that the buildID wasn't compiled in the with the flag -ldflags "buildid=" . I will do some more testing and update the issue.

[capnspacehook]

Thanks for the quick fix! Tested the upgraded redress and the issue is fixed!