Coder Social home page Coder Social logo

Comments (7)

hwbrzzl avatar hwbrzzl commented on July 18, 2024 1

Thanks! please enrich more unit tests like the above.

from goravel.

hwbrzzl avatar hwbrzzl commented on July 18, 2024 1

Hi @sidshrivastav , hope you have a great weekend.

FYI, we are going to release 1.10.0 in recent days, if there is a chance that merging this feature into master will be great.

There is the v1.10.0 upgrade guide:
image

from goravel.

sidshrivastav avatar sidshrivastav commented on July 18, 2024 1

I'll push the PR by tomorrow.

from goravel.

sidshrivastav avatar sidshrivastav commented on July 18, 2024

Hey @hwbrzzl, it this something you want to add in framework, I can see the Config interface but do you want to add it for Config?

from goravel.

hwbrzzl avatar hwbrzzl commented on July 18, 2024

Oh sorry @sidshrivastav , just missed this message. I reviewed this requirement and think just changing Add(name string, configuration map[string]any) to Add(name string, configuration any) in contracts/config/config/go is ok, then we can achieve:

facades.Config.Add("test", map[string]any{"a", "b"})
facades.Config.Get("test.a") // b
facades.Config.Add("test.test1", "c")
facades.Config.Get("test.test1") // c

from goravel.

hwbrzzl avatar hwbrzzl commented on July 18, 2024

If you have interesting in this, please take a look, thanks! @sidshrivastav

from goravel.

sidshrivastav avatar sidshrivastav commented on July 18, 2024

Sure, you can assign it to me. I'll work on it during the weekend.

from goravel.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.