Coder Social home page Coder Social logo

Comments (1)

burkedavison avatar burkedavison commented on August 17, 2024 1

Hello @deionalims - thank you for your bug report. I agree, the writer should be closed and have put up a PR to fix it.

Also, the BigQueryJsonDataWriter is instantiated every time a call to BigQueryTemplate.writeJsonStream() is made. As I make several calls to BigQueryTemplate.writeJsonStream() in my application, wouldn't it be more efficient to instantiate it once and give the control to the user to close it when needed ?

While different design decisions could've been made when creating this module, it's now important that we maintain the existing contract to avoid introducing breaking changes. Also - introducing a writer that can be reused opens the possibility of user error if they attempt to write to a different parent table, and raises potential multithreaded concerns.

from spring-cloud-gcp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.