Coder Social home page Coder Social logo

Comments (4)

dekkagaijin avatar dekkagaijin commented on May 28, 2024 1

We've recently experienced the same issue with gcloud, as well, thanks for the report. As mentioned, configure-docker fails open, so this should only be an annoyance in practice. We check the version of the docker client for a couple reasons-
a) to verify that docker is visible on the path
b) to configure itself as a credential store for client versions 1.11 and 1.12.

from docker-credential-gcr.

tmshn avatar tmshn commented on May 28, 2024 1

imo, all we need is client version, so we can use docker --version instead of docker version

from docker-credential-gcr.

dekkagaijin avatar dekkagaijin commented on May 28, 2024

Added more clarification to that warning, for cases like this: #45

I'm inclined to lean on helpful warning text more so than fancy error correction logic, since checking docker version can fail for any number of reasons which don't impact the function of the cred helper. Hopefully this updated error text will allow for users to verify that nothing's actually amiss...

from docker-credential-gcr.

dekkagaijin avatar dekkagaijin commented on May 28, 2024

configure-docker no longer checks the Docker client version:
https://github.com/GoogleCloudPlatform/docker-credential-gcr/releases/tag/v2.0.0

from docker-credential-gcr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.