Comments (5)
I like it. How do we guarantee ordering? (You could put at rest before initial), and how do we order within the set of gathers scheduled for a given lifecycle point? Last question: who instructs the driver to move to the next stage?
from lighthouse.
I am pretty convinced that some gather operations will be destructive (cause the browser to be in a state where no other gathers can run)
For now, allowing the gather to do whatever will continue to work, I think this is a deep deep rabbit hole if we start trying to optimize the gather phase. I am totally with you that the more times we revisit the page the more variance we will get (if we gather the same number twice) But I am not so convinced of the upside of trying to optimize the gather phase to reduce the number of reloads given the complexity cost of this task.
So long as each gather phase exits cleanly everything should be "OK"
For drool, i setup basic life-cycle hooks that you could put logic in for each memory test, that seemed to work out pretty OK for me.
https://github.com/samccone/drool/blob/master/docs/api.md#flow
from lighthouse.
Tried to capture a few usecase for timing in this doc: https://v.etherpad.org/p/MCiOMkGOcf
@deepanjanroy was thinking it may make more sense to have gathers extend a base class that has these lifecycle events defined.. e.g. setup, beforeLoaded, pageLoaded, teardown.
This is in line with how Telemetry does it, in fact. In key_silk_cases.py see __init__
, RunNavigateSteps
, RunPageInteractions
PerformPageInteractions
from lighthouse.
There's already a gather base class IIRC so we should be gtg there.
from lighthouse.
Yyyyyyyeah https://github.com/GoogleChrome/lighthouse/blob/master/gatherers/gather.js
from lighthouse.
Related Issues (20)
- Running Lighthouse in Typescript Github Action HOT 1
- Owner
- Screenshot (Jul 28, 2024 2:15:19 AM)
- How can I run Lighthouse audits in a ReactJS application, similar to using web-vitals for onCLS, onLCP, etc.
- Update Sentry SDK to v8
- Total Blocking Time wrong HOT 1
- Report
- roblox HOT 2
- error message for websites using websocket could be improved HOT 1
- No throw still HOT 2
- LCP over 22 000 ms at Lighthouse HOT 1
- [email protected]
- Dark mode preference reset when changing language
- Update puppeteer types to accept `puppeteer-core` from outside Lighthouse HOT 3
- Unable to resolve <WEBSITELINK> Try checking the URL for validity HOT 4
- NO_LCP on Mobile but there is one on Desktop HOT 4
- Consider adding `summary-name` axe rule
- PageSpeed Insights Failed: net::ERR_NAME_NOT_RESOLVED HOT 2
- "Show audits relevant to" not shown on report from PageSpeed Insights API HOT 3
- PageSpeed Insights Issue: "Lost Browser Connection" on Product URL HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lighthouse.