Coder Social home page Coder Social logo

Comments (11)

paulirish avatar paulirish commented on May 1, 2024 9

@two7sclash evaluate this after lighthouse is required:

self.setImmediate = function(callback, ...argsForCallback) {
  Promise.resolve().then(() => callback(...argsForCallback));
  return 0;
};

sorry for this, guys.

from lighthouse.

mohsen1 avatar mohsen1 commented on May 1, 2024 3

Still seeing this in TravisCI when I launch chrome programmatically

from lighthouse.

paulirish avatar paulirish commented on May 1, 2024 1

Just ran into this problem again, while working on pwmetrics.. here's what I found out:

the _destroySSL stuff is happening inside _tls_wrap, which the request module uses:
image

As you can see, the this is passed as a parameter to setImmediate but a heartbeat later, that param isn't there. And why not?

chrome-devtools-frontend has been polyfilling setImmediate, and unfortunately for us... incorrectly:
image

:)


Update: I'm submitting a patch to fix it in devtools

from lighthouse.

gauntface avatar gauntface commented on May 1, 2024

Looks like:

TypeError: Cannot read property '_destroySSL' of undefined
at destroySSL (_tls_wrap.js:370:7)

is coming from the chrome remote interface close() call. Not sure there is anything that can be done to silence the error

from lighthouse.

paulirish avatar paulirish commented on May 1, 2024

I tried to diagnose this exception but only got so far. I'm pretty sure it's a node core bug, as that area (_tls_wrap.js) has gotten some fixes.

from lighthouse.

paulirish avatar paulirish commented on May 1, 2024

TypeError: Cannot read property '_destroySSL' of undefined at destroySSL (_tls_wrap.js:370:7)

Took another stab last night. AFAIK, this is due to the request call for the manifest, and not cri's close(). 😌 So we'll be done with it soon.

from lighthouse.

paulirish avatar paulirish commented on May 1, 2024

Broke out the other two issues into #106 and #105.

Retitled this to be just the destroySSL. This will be fixed when #83 is done. \o/

from lighthouse.

paulirish avatar paulirish commented on May 1, 2024

fixed by #83

from lighthouse.

ebidel avatar ebidel commented on May 1, 2024

I just ran into this using lighthouse 1.4.1 as a submodule. @paulirish did you ever submit a CL for devtools?

from lighthouse.

paulirish avatar paulirish commented on May 1, 2024

Yes. Fixed over there: https://codereview.chromium.org/2615083002

But we'll need to bump our dependency to handle the update: #1535

from lighthouse.

two7sclash-zz avatar two7sclash-zz commented on May 1, 2024

still seeing this too, running lighthouse on heroku.

from lighthouse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.