Comments (7)
@brendankenny i think we have the pieces for this. can you hook them up to an aggregator so it gets surfaced?
from lighthouse.
I have a PR up that'll take care of this.
from lighthouse.
@mounirlamouri question that came up in #104.. what happens if color are specified in both meta and manifest and they differ?
from lighthouse.
If theme_color
is defined in the Manifest, it will be used as a default theme_color
. Each page can then override it using the meta
tag. Though, using the Manifest theme_color
has the added benefit of being used for the splash screen.
from lighthouse.
Perfect. That's just what we needed to know. Thanks!
from lighthouse.
I think I still don't understand the purpose of this audit. Maybe it's just that the title of this issue is throwing me off. What are brand colors? :)
Is the idea:
- Chrome won't by default fetch the manifest, so
<meta> theme-color
is needed - When Chrome does fetch the manifest, it will use the manifest's
theme_color
for things like the splash screen, so you need it there too
but if the <meta> theme-color
overrides the manifest theme_color
, do you need a manifest one for the omnibox if you have a <meta>
one? It seems like one or the other is sufficient, unless you want a splash screen color as well?
from lighthouse.
Oh, I might be missing the other way. If you have a theme_color
in your manifest, you need a <meta> theme-color
in your page because we don't currently fetch the manifest on page load.
But it seems like if you have a <meta> theme-color
, the manifest theme_color
should be optional still?
from lighthouse.
Related Issues (20)
- Unexpected Cookie/opensearch.xml error in console HOT 3
- Discrepancy between LCP measurement and actual element render HOT 4
- Page loads very slowly due to CSS.enable HOT 5
- 12367
- Screenshot (Jul 21, 2024 8:17:52 AM) https://github.com/GoogleChrome/lighthouse/issues/16125 https://www.apache.org/licenses/LICENSE-2.0.txt
- Mobile mode is not working even after giving mobile configuration from lighthouse HOT 4
- Running Lighthouse in Typescript Github Action HOT 1
- Owner
- Screenshot (Jul 28, 2024 2:15:19 AM)
- How can I run Lighthouse audits in a ReactJS application, similar to using web-vitals for onCLS, onLCP, etc.
- Update Sentry SDK to v8
- Total Blocking Time wrong HOT 1
- Report
- roblox HOT 2
- error message for websites using websocket could be improved HOT 1
- No throw still HOT 2
- LCP over 22 000 ms at Lighthouse HOT 1
- [email protected]
- Dark mode preference reset when changing language
- Update puppeteer types to accept `puppeteer-core` from outside Lighthouse HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lighthouse.