Comments (3)
I backfilled the gates on staging and prod.
You should now see gates for Enterprise, Debuggability, Testing, and API Owners. The button to generate the email is now part of the API Owners gate and it should work.
There is also a coding error in the case where there is a legitimate gate-less action, for example "Draft Ready for Developer Testing email". I will send a PR for a fix, and try to get it into our next release.
from chromium-dashboard.
I can repro this on some deprecation feature entries on staging.
I think the root cause is that in #3659 I added gates and this action to this stage, but we did not backfill gates on existing feature entries. That by itself is OK because the feature owners of existing deprecation feature entries could continue to generate these emails by hand like they were doing before my PR. For those old feature entries, the action button to generate the email would not have been displayed anywhere because the gate that it was part of did not exist on those feature entries.
However, the button became visible to users after #3773 merged. That PR displays buttons for actions on stages that have no gates. It should not display this button because that stage should have gates.
Possible solutions:
- BEST: Backfill gates on the plan stage of old deprecation feature entries
- Add logic to not show this particular action button even though it looks like a gate-less stage action.
- Allow the owners of old deprecations to generate the email without gates, which would be a confusing mix of old and new processes.
from chromium-dashboard.
Since it sounds like there should have been a gate, any idea which gate I missed that I should be going through before I click this button?
from chromium-dashboard.
Related Issues (20)
- Chrome Status Entry sends a lot of emails when an edit is submitted to the feature. HOT 3
- Features should not show up on the roadmap as shipping purely based on browser version number in prepare to ship HOT 2
- "OT Contacts" argument needs to be added to OT creation Chromestatus request HOT 1
- A new enum field should be added to Stage to represent the creation status of the origin trial HOT 1
- OT Creation/Activation endpoints need to be started and tested
- Activity log entries miss important information
- OT creation does not work as intended, pre Chromestatus-OT automation HOT 4
- Feature with 3 OT stages has 2 of them pointing to the same trial ID HOT 4
- Trial name should be limited to 63 characters in trial creation HOT 2
- Make the advice to write unit tests for OT more prominent
- Duplicate and missing web features
- Report on the state of feature verification
- The OT creation form should accept WebDX Feature counters too
- OT extension request data moved to old blank extension stage
- Outbound emails failures when to=[] HOT 1
- Use another project name for the local datastore emulator
- Don't require other gate approval prior to API owners
- Restore comments on ChromedashToast.showMessage
- Mta-sts.croydon.gov.uk HOT 3
- Add functionality to have Playwright tests mimic admin actions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chromium-dashboard.