Coder Social home page Coder Social logo

Comments (3)

nicain avatar nicain commented on July 22, 2024

Looks like we need to add a (app: Probot).on("push") filtered by a regex against a regex configured in the config file. Then a new function will be needed similar to scanPullRequest ("scanBranch" ?) will be needed, which builds from the result of Octokit.branch.

from repo-automation-bots.

chingor13 avatar chingor13 commented on July 22, 2024

For scanning a PR, I don't see anything in the code restricting which base branch it runs against.

For the nightly scanning of the repo, that could be something that we add configuration for and run on multiple branches.

from repo-automation-bots.

nicain avatar nicain commented on July 22, 2024

For scanning a PR, I don't see anything in the code restricting which base branch it runs against.

I agree! so it comes down to a question of triggering, right?

As best I can tell, GH Merge Queue (MQ) will create a branch conforming to the regex: gh-readonly-queue/main/pr-.* when the user presses the "Merge When Read" button (which replaces the "Squash and Merge" button, when MQ is activated on the branch)

This new branch adds a new commit to the PR feature branch, but I don't think it emits any events that the snippet-bot (scanning the PR) would be able to trigger on. Also, snippet-bot would need to figure out which commit (HEAD of the new regex-conforming branch) to verify.

from repo-automation-bots.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.