Comments (4)
I took a different pass at this with local_paths
, which allows each repository to either be derived from reporoot
or explicitly defined. I assert it probably solves for this problem.
Note that in the remote pipeline, we will just check out the applicable repos. I think that is orthogonal to this issue, though.
All paths except the old gapic_code_dir
(which used to be final_repo_dir
) no longer derive from ${REPOROOT}
. I actually intend to scrap gapic_code_dir
completely and just make it an automatically determined temporary directory (/tmp/{uuid.uuid4()[0:8]}/
), since it is no longer used to determine code's final staging location (except when using --publish=noop
, which we do not even document).
from artman.
@lukesneeringer For context, this issue was originally raised by some of our users who were running the remote pipeline with protos that were not yet checked into the applicable repos; we supported a phase in which the users specified a local directory that was then uploaded and merged into a clone of the googleapis
repo. This caused quite a lot of confusion from our users about what files were coming from where.
from artman.
I see. My changes do not really make that particular problem much better (although they certainly do not make it any worse). Really the issue is not with reporoot
, it is with googleapis
.
The ultimate solution to this problem is probably to infer basically everything that is not in the artman or GAPIC YAML files; we do not really need to outright specify lang/common.yaml
every time; it would be entirely okay to simply make everything in that file settings that can be specified in a user YAML but which have these defaults otherwise.
This clearly needs more design work. Leaving this issue in place.
from artman.
This is no longer required under new artman syntax.
from artman.
Related Issues (20)
- Missing input file. should be more descriptive HOT 7
- Go: run goimports as part of artman script HOT 15
- Go: release level not being considered HOT 3
- Switch to composer from pear for PHP dependencies HOT 5
- Python: include enums in generated documentation HOT 5
- Error while finding module specification for 'grpc_tools.protoc' (ModuleNotFoundError: No module named 'grpc_tools') HOT 6
- Typos in CONTRIBUTING.rst
- Nested package proto imports fail for Python HOT 2
- --local runs are broken HOT 3
- Samples are not being generated (as of 0.29.1) HOT 3
- Add sample generation to golden test (to catch samplegen regressions) HOT 2
- artman: pull the artman image for me HOT 4
- module has no attribute FullLoader HOT 1
- mysterious error HOT 1
- un-whitelist monitoring
- Java: update protoc plugin
- fix cel API generation HOT 4
- allow passing extra command line options to protoc HOT 1
- Does not work on the github.com/google/fhir protobufs?
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artman.