Coder Social home page Coder Social logo

API naming variable changes about artman HOT 6 CLOSED

googleapis avatar googleapis commented on May 29, 2024
API naming variable changes

from artman.

Comments (6)

geigerj avatar geigerj commented on May 29, 2024

See this commit for an example of how this might be done in artman naively:
geigerj@b2ed709

from artman.

geigerj avatar geigerj commented on May 29, 2024

My concern with this is that it means the artman output directory always references Google Cloud, even if the API is not a Cloud API. Maybe we can introduce a new flag cloud_api to the artman common.yaml config file that only prefixes google-cloud- to the API name if the flag is set.

from artman.

jskeet avatar jskeet commented on May 29, 2024

I wouldn't be at all surprised if the C# title needed to be specified by hand either way, to be honest. It might be worth having a "default" based on the four variables you've said, but have an escape hatch for any that are awkward for whatever reason.

from artman.

geigerj avatar geigerj commented on May 29, 2024

@jskeet That's true; constructing API Name with default value of google-cloud-{short name}-{version} shouldn't preclude making it configurable later.

AFAICT, C# currently only uses this configuration parameter to create an intermediate output directory during the code generation pipeline -- it's not actually passed into any of the tools, so I don't expect it to be affected in by this change.

from artman.

geigerj avatar geigerj commented on May 29, 2024

Downgrading priority and removing "blocking beta" label, as after #811 this is internal cleanup rather than a bug.

from artman.

geigerj avatar geigerj commented on May 29, 2024

This was fixed by #123 and #124

from artman.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.