Comments (6)
See this commit for an example of how this might be done in artman naively:
geigerj@b2ed709
from artman.
My concern with this is that it means the artman
output directory always references Google Cloud, even if the API is not a Cloud API. Maybe we can introduce a new flag cloud_api
to the artman common.yaml
config file that only prefixes google-cloud-
to the API name if the flag is set.
from artman.
I wouldn't be at all surprised if the C# title needed to be specified by hand either way, to be honest. It might be worth having a "default" based on the four variables you've said, but have an escape hatch for any that are awkward for whatever reason.
from artman.
@jskeet That's true; constructing API Name with default value of google-cloud-{short name}-{version}
shouldn't preclude making it configurable later.
AFAICT, C# currently only uses this configuration parameter to create an intermediate output directory during the code generation pipeline -- it's not actually passed into any of the tools, so I don't expect it to be affected in by this change.
from artman.
Downgrading priority and removing "blocking beta" label, as after #811 this is internal cleanup rather than a bug.
from artman.
This was fixed by #123 and #124
from artman.
Related Issues (20)
- Missing input file. should be more descriptive HOT 7
- Go: run goimports as part of artman script HOT 15
- Go: release level not being considered HOT 3
- Switch to composer from pear for PHP dependencies HOT 5
- Python: include enums in generated documentation HOT 5
- Error while finding module specification for 'grpc_tools.protoc' (ModuleNotFoundError: No module named 'grpc_tools') HOT 6
- Typos in CONTRIBUTING.rst
- Nested package proto imports fail for Python HOT 2
- --local runs are broken HOT 3
- Samples are not being generated (as of 0.29.1) HOT 3
- Add sample generation to golden test (to catch samplegen regressions) HOT 2
- artman: pull the artman image for me HOT 4
- module has no attribute FullLoader HOT 1
- mysterious error HOT 1
- un-whitelist monitoring
- Java: update protoc plugin
- fix cel API generation HOT 4
- allow passing extra command line options to protoc HOT 1
- Does not work on the github.com/google/fhir protobufs?
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artman.