Comments (10)
In this particular case, I'd prefer 'generate_package_metadata' since it explicitly indicates whether we want to generate package metadata or not.
from artman.
from artman.
Possible suggestions for renaming: package_metadata
, standalone_package
, package
?
from artman.
some random ideas: 'generate_package_files', 'source_only'
from artman.
package_metadata
might be good. I like it.
from artman.
cc: @bjwatson too
from artman.
@pongad added a new config field into the GAPIC yaml named domain_layer_location
which I think could serve for this purpose. The real "data" is if there is a domain layer for the API; the skip_packman
field is just a specific action that should be taken as a result. The challenge is that the config line is in GAPIC yaml instead of artman yaml. Over time, I think we will be encountering more configuration like this, where the language+API-specific information needs to be used both by the generator and also outside of the generator (in the artman process).
from artman.
There will be always arguments around names. :)
'domain_layer_location' sounds non-intuitive too if that's a configuration item exposed to a user.
from artman.
Want to revisit this issue. Since parts of package generations are moving to toolkit, the name skip_packman
does not make much sense.
from artman.
The whole skip_packman
has been deprecated in the new artman config syntax.
from artman.
Related Issues (20)
- Missing input file. should be more descriptive HOT 7
- Go: run goimports as part of artman script HOT 15
- Go: release level not being considered HOT 3
- Switch to composer from pear for PHP dependencies HOT 5
- Python: include enums in generated documentation HOT 5
- Error while finding module specification for 'grpc_tools.protoc' (ModuleNotFoundError: No module named 'grpc_tools') HOT 6
- Typos in CONTRIBUTING.rst
- Nested package proto imports fail for Python HOT 2
- --local runs are broken HOT 3
- Samples are not being generated (as of 0.29.1) HOT 3
- Add sample generation to golden test (to catch samplegen regressions) HOT 2
- artman: pull the artman image for me HOT 4
- module has no attribute FullLoader HOT 1
- mysterious error HOT 1
- un-whitelist monitoring
- Java: update protoc plugin
- fix cel API generation HOT 4
- allow passing extra command line options to protoc HOT 1
- Does not work on the github.com/google/fhir protobufs?
- Action Required: Fix Renovate Configuration
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from artman.