Comments (9)
For reference; lvandeve/lodepng#109
from zopfli.
I updated lodepng again in commit 2f940d2, does this fix it it for you?
Thank you
from zopfli.
Unfortunately it did not: https://ci.appveyor.com/project/EwoutH/zopfli/builds/28410278/job/47laf4tngkfpjdpp
from zopfli.
@EwoutH thanks for the second link. It shows an error on line 306:
"C:\projects\zopfli\src\zopflipng\lodepng\lodepng_util.cpp(306,1): error C2124: divide or mod by zero [C:\projects\zopfli\cmake_build\libzopflipng.vcxproj]"
But I have on line 306 the following, so it's odd that it gives a division through zero error for that particular line (and not earlier ones)
"return (x < -lodepng_flt_max) ? (y < 0 ? 0 : lodepng_flt_inf) :"
Can you please verify what you see on line 306?
Thank you
from zopfli.
@lvandeve The same I'm afraid.
return (x < -lodepng_flt_max) ? (y < 0 ? 0 : lodepng_flt_inf) :
from zopfli.
@EwoutH would you be willing to experiment a bit, e.g. removing "static const" from lodepng_flt_zero_" on line 285, or, remove "static const" from all three lines there?
The actual division through zero after commit 2f940d2 is on lines 286 and 287.
I haven't got this compiler available, and g++/clang++ don't give this error, so it would be very helpful to diagnose the problem that way.
Thank you :)
from zopfli.
@lvandeve Yes, replacing static const float
by float
on line 285 solves the division error and makes it compile correctly!
There are still about 70 warnings though, including a lot in lodepng.
from zopfli.
@EwoutH say:
There are still about 70 warnings though, including a lot in lodepng.
from zopfli.
The referenced commit should fix the error.
Thanks for the warning log, that's independent from this issue, closing since it should be fixed
from zopfli.
Related Issues (20)
- how to working in iOS? HOT 1
- Do not emit compressed files larger than the input
- Add lgtm to the repo and fix its issues
- better cmake build
- compiler warnings
- Order of colors in PLTE not kept anymore
- Zopflipng picks up crc errors in input files, offers to disable checks, but no crc check disable switch found
- Null Dereference
- Would you please describe the zopfli block-splitting heuristic? HOT 1
- using `--lossy_transparent` option sometimes results in higher file size
- Incorrect ZopfliPNG static library build rule
- verification of result failed HOT 1
- Time for a new release? HOT 2
- Document ZopfliDeflate parameters
- Assertion failed on ZopfliCalculateBitLengths at zopfli/src/zopfli/tree.c:100
- unnecessary `else` statement.
- Android
- OSS-Fuzz issue 57919
- One order HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zopfli.