Coder Social home page Coder Social logo

Comments (1)

DubeySandeep avatar DubeySandeep commented on June 23, 2024

Hi @kchen05, I was investigating around this issue and found it's reproducible even if you will press "tab" key just after changing the theme.

I found that with tab key press or on clicking on the scroll bar the Codemirror get focused (you can see a borderline) and the CodeMirror gets into the accessible mode, whereas when we are changing the theme we are only changing the codeMirrorOptions.theme

$scope.changeTheme = function(newThemeName) {
$scope.pulseAnimationEnabled = false;
if (newThemeName === THEME_NAME_DARK) {
$scope.codeMirrorOptions.theme = 'mbo';
} else {
$scope.codeMirrorOptions.theme = 'default';
}

We should also change the $scope.accessibleCodeMirrorOptions.theme.
Currently, I'm not pretty aware of "accessibleMode" so I don't know whether it's an expected behavior or not (clicking on scroll bar should make the Codemirror into accessible mode). If it's an expected behavior then I'll send a PR! :)

One more issue I found:
On changing theme the scrollbar style remains the same till you click on it.

from tie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.