Coder Social home page Coder Social logo

Comments (5)

sirdarckcat avatar sirdarckcat commented on May 11, 2024

This will also be obsolete when #1 is fixed, but it's worth doing first, since it's a small change.

from tamperchrome.

sirdarckcat avatar sirdarckcat commented on May 11, 2024

@eliyastein since you made some changes recently here, are you interested on this? it's a small patch and it is similar to your last change, except here we need to check the response on

chrome.runtime.sendMessage(appId, 'sup', {}, function(){});
to confirm the extension is installed before showing the message here
if (xmp.responseText != 'Hello') {

in other words, before showing appNotFound() we need to check if background.js' message to the background app actually failed (or not).

https://developer.chrome.com/extensions/messaging#external

from tamperchrome.

eliyastein avatar eliyastein commented on May 11, 2024

@sirdarckcat - Happy to take a look, but might be a week or so before I can get to it.

from tamperchrome.

sirdarckcat avatar sirdarckcat commented on May 11, 2024

thanks! that works for me :)

from tamperchrome.

sirdarckcat avatar sirdarckcat commented on May 11, 2024

#18 and #31 obsolete the chrome app completely, so closing this

from tamperchrome.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.