Assertion failed: (EB.get(&I)->hasOrigin(&I)), function ExtractExprCandidates, file .../lib/Extractor/Candidates.cpp, line 1025 about souper

[ychen306]

In my custom pipeline, I make sure souper is run before instcombine. Maybe that uncovered the issue.

[ychen306]

Seems like in https://github.com/google/souper/blob/main/lib/Extractor/Candidates.cpp#L1025,
the assertion should be something like (because an LLVM instruction can get mapped to a souper constant)

      assert(EB.get(&I)->K == Inst::Const || EB.get(&I)->hasOrigin(&I));

instead of

      assert(EB.get(&I)->hasOrigin(&I));

[regehr]

thanks for the bug report! I'll look at it Monday

[regehr]

fixed via #823

thanks for this-- I really don't understand how we never noticed this before

[ychen306]

I ran souper at various places in the optimization pipeline instead of just at the end. My guess is that LLVM's typical optimization gets rid of this kind of patterns.

[regehr]

I'm somewhat satisfied with this explanation, but souper doesn't just run at the end. when you load it as an opt pass, it gets run 5 times, throughout the optimization pipeline. but it always runs after the same passes, so that could have hidden this issue!