Comments (4)
@mohitwp Thank you for the observation. Yeah, I was trying to see if I can find a way around it to make it smaller, but couldn't fit it, as we need to show the error message, it is a bit longer than most content in the KM widgets, and making the font size smaller didn't help. So not sure we can do much about it, as this will catch the error within the widget, and if there is a problem, it will affect the functioning of the widget itself, showing the error, so layout being expanded a bit, doesn't seem much of priority, since fixing the issue would resolve that, and there is also a possibility error is temporary and on next visit it will be gone. as this will be shown only in very rare cases that one of the widgets actually encounter the error.
You can potentially open a new issue, so we can see if any different decision can be made on this, or if it will be needed.
from site-kit-wp.
IB ✔️
from site-kit-wp.
QA Update ⚠️
- Tested on dev environment.
- Tested using Tweak extension.
- Generated error on main dashboard and verified that Ga4 event gets track for each error.
- Verified event_category: "widget_error" , "event", "handle_mainDashboard_error" and and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4')
- Verified that errors are showing as per AC.
- Verified link appearing under error and copy content functionality.
@zutigrm I’ve noticed that the height of KM widgets increases when an error message is displayed, causing misalignment of the widget's content. Should I create a new issue for this, or can it be addressed in a follow up PR?
PASS CASES
event_category: "widget_error" , "event", "handle_mainDashboard_error", and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4)
from site-kit-wp.
QA Update ✅
Thank you @zutigrm !
- Tested on dev environment.
- Tested using Tweak extension.
- Generated error on main dashboard and verified that Ga4 event gets track for each error.
- Verified event_category: "widget_error" , "event", "handle_mainDashboard_error" and and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4')
- Verified that errors are showing as per AC.
- Verified link appearing under error and copy content functionality.
event_category: "widget_error" , "event", "handle_mainDashboard_error", and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4)
from site-kit-wp.
Related Issues (20)
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.` HOT 2
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
- Extract the audience utility logic from `Analytics_4` to a new class.
- Fix glitches in the Audience Segmentation Setup CTA Banner
- "Looks like your site is not allowed access to Google account data" error, despite no changes made HOT 2
- PAX application not loading correctly on the Ads setup screen.
- Column Titles Overlapping in 'Top Content Over the Last X Days' Widget on Narrow Viewports.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.