Coder Social home page Coder Social logo

Comments (4)

zutigrm avatar zutigrm commented on August 28, 2024 1

@mohitwp Thank you for the observation. Yeah, I was trying to see if I can find a way around it to make it smaller, but couldn't fit it, as we need to show the error message, it is a bit longer than most content in the KM widgets, and making the font size smaller didn't help. So not sure we can do much about it, as this will catch the error within the widget, and if there is a problem, it will affect the functioning of the widget itself, showing the error, so layout being expanded a bit, doesn't seem much of priority, since fixing the issue would resolve that, and there is also a possibility error is temporary and on next visit it will be gone. as this will be shown only in very rare cases that one of the widgets actually encounter the error.

You can potentially open a new issue, so we can see if any different decision can be made on this, or if it will be needed.

from site-kit-wp.

eugene-manuilov avatar eugene-manuilov commented on August 28, 2024

IB ✔️

from site-kit-wp.

mohitwp avatar mohitwp commented on August 28, 2024

QA Update ⚠️

  • Tested on dev environment.
  • Tested using Tweak extension.
  • Generated error on main dashboard and verified that Ga4 event gets track for each error.
  • Verified event_category: "widget_error" , "event", "handle_mainDashboard_error" and and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4')
  • Verified that errors are showing as per AC.
  • Verified link appearing under error and copy content functionality.

@zutigrm I’ve noticed that the height of KM widgets increases when an error message is displayed, causing misalignment of the widget's content. Should I create a new issue for this, or can it be addressed in a follow up PR?

image

image

image

PASS CASES

event_category: "widget_error" , "event", "handle_mainDashboard_error", and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4)

image

image

image

image

image

image

image

from site-kit-wp.

mohitwp avatar mohitwp commented on August 28, 2024

QA Update ✅

Thank you @zutigrm !

  • Tested on dev environment.
  • Tested using Tweak extension.
  • Generated error on main dashboard and verified that Ga4 event gets track for each error.
  • Verified event_category: "widget_error" , "event", "handle_mainDashboard_error" and and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4')
  • Verified that errors are showing as per AC.
  • Verified link appearing under error and copy content functionality.

event_category: "widget_error" , "event", "handle_mainDashboard_error", and event_label: include widget slug prefix, (Example- "analyticsAllTrafficGA4)

image

image

image

image

image

image

image

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.