Comments (3)
@aaemnnosttv during replacement of color variables with tokens, I noticed that some of the variables have tokens associate with them, and some not, while others are only defined in _variables.scss
but not in _variables-mui3.scss
. Here are said findings:
$c-neutral-n-400 // Has no color token equivalent.
$c-neutral-n-700 // Has no color token equivalent.
$c-neutral-n-66 // Has no color token equivalent.
$c-green-g-50 // Has no color token equivalent.
$c-red-600 // Only defined in assets/sass/config/_variables.scss and not in assets/sass/config/_variables-mui3.scss
$c-blue-b-500 // Has no color token equivalent.
$c-blue-b-50 // Has no color token equivalent.
$c-blue-b-600 // Has no color token equivalent.
$c-blue-b-400 // Has no color token equivalent.
$c-yellow-y-100 // Has no color token equivalent.
$c-yellow-y-600 // Has no color token equivalent.
$c-yellow-900 // Only defined in assets/sass/config/_variables.scss and not in assets/sass/config/_variables-mui3.scss
$c-violet-v-0 // Has no color token equivalent.
$c-violet-v-500 // Has no color token equivalent.
Those that had token equivalents were replaced throughout the codebase.
from site-kit-wp.
IB ✅
from site-kit-wp.
Moving directly to Approval as no QA is needed here.
from site-kit-wp.
Related Issues (20)
- Creation of `Top cities driving purchases` ACR KMW
- Creation of `Top cities driving purchases` ACR KMW
- Creation of `Top device driving purchases` ACR KMW
- Creation of `Top device driving purchases` ACR KMW
- Creation of `Top traffic source driving purchases` ACR KMW
- Glitches / errors when changing the audience selection in mobile viewports
- Impossible to stop tagmanager code placement HOT 1
- Agency with hundreds of client Google Analytics accounts unable to assign correct profiles HOT 2
- Remove `conversionInfra` feature flag
- Remove localization for module homepage URLs
- Improve the `resetPublications` action HOT 6
- Requests made for module settings on dashboard
- Implement Internal Measurement/Tracking Following ACR KMW Updates
- Enhance compatibility with Docker locally for E2E
- Refactor the `ZeroDataNotification` to use the new lighter `Notification` component. HOT 5
- Release 1.134.0 HOT 4
- Add "Edit in Reader Revenue Manager" link for the RRM module
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.