Comments (4)
@benbowler Adding invariant
checks makes sense, let's do that too 👍🏻
Also, while it wasn't in the ACs, let's add it to at least one component so we can QA it properly 👍🏻 I've added refactoring [GA4AdSenseLinkedNotification.js](https://github.com/google/site-kit-wp/blob/4cce042da8831b2ec8663e4d9767bc0610ae4e5a/assets/js/components/notifications/GA4AdSenseLinkedNotification.js#L115-L121)
to the ACs 🙂
from site-kit-wp.
Created the IB. Some possible additions/questions:
- We could add something like
invariant
if the user passes invalid prop combinations like both and include and exclude list or both view only and non view only? - I assumed we weren't using this new HOC yet in this ticket? Otherwise we could add a case/some cases to refactor as part of this work.
from site-kit-wp.
Looks good to me 👍🏻
IB ✅
from site-kit-wp.
QA Update ✅
- Tested on main environment.
- Verified AdSense set up for the website that has AdSense linked with Analytics.
- Verified AdSense set up for the website that has AdSense not linked with Analytics.
- Verified the notice when AdSense linked with analytics and when it's not linked.
- Verified that no notification related to it appearing under settings.
When AdSense linked with Analytics
Recording.1215.mp4
When AdSense not linked with Analytics
Recording.1216.mp4
from site-kit-wp.
Related Issues (20)
- Enhance compatibility with Docker locally for E2E
- Refactor the `ZeroDataNotification` to use the new lighter `Notification` component. HOT 5
- Release 1.134.0 HOT 4
- Add "Edit in Reader Revenue Manager" link for the RRM module
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.` HOT 2
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
- Extract the audience utility logic from `Analytics_4` to a new class.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.