Comments (11)
@zutigrm re. your question.
LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
It was decided due to the high profile of the consent mode functionality that we should include it in the entity dashboard too. I am sure Tom can confirm this is the case.
from site-kit-wp.
LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
@zutigrm yes, it was defined that way in #8279 👍
from site-kit-wp.
QA Update ✅
Tests included but not limited to:
- Plugin setup (activation, deactivation, deletion)
- Disconnect & Reset Plugin
- Module Connection & Setup
- Ad Blocker testing
- Help Menu
- User Menu
- Module Settings
- Module Functionality
Nothing to report. LGTM!
from site-kit-wp.
Release Testing ✔️
- Went through the release testing checklist on a new site.
- Tested AdSense, Ads, Analytics and Tag Manager module.
- Tested User Input and Key Metrics on Main and shared dashboard.
- Tested Ad Blocking Recovery.
LGTM. 👍
from site-kit-wp.
QA ✅
- Went through new site setup and upgraded an existing site.
- Tested Ads and other modules.
- Tested Key Metrics on existing site.
- Tested Dashboard Sharing.
All looks good to me 👍🏻
from site-kit-wp.
QA Update: ✅
I went through our usual QA checks:
- Tested on a site in gathering and zero data state
- Tested on a site with live data
- Tested Dashboard sharing
- Tested Ad Blocking Recovery
- Tested Enhanced Measurement
- Tested User Input and KMW widget
- Tested Consent Mode
- Tested AdSense+GA4 Integration
- Tested the Ads Module
Note: I ran some quick UI checks on the application screen for NPT and also ran through some additional testing around 2nd admin users as we've had a few bug tickets recently around 2nd admins.
from site-kit-wp.
QA Verified ✅
- Smoke tested
- Tested available modules, and Ads related logic
- Tested Key metrics
- Tested dashboard sharing and entity dashboard
- Tested ad blocking behaviour of Ads and AdSense
- Performed ad hoc testing
LGTM, I just have one question. We usually don't display any banners on Entity dashboard, as much as I know, although Consent mode one is displayed there now. Is this expected?
from site-kit-wp.
Release Tested ✅
- Release tested 1.127.0 thoroughly.
- Set everything up from scratch on a live (TasteWP) site.
- Didn't spot any unexpected console errors.
- Verified UI in different device breakpoints.
- Verified changes I've been involved with.
- Used the release testing checklist to ensure everything was checked.
- Tested Dashboard Sharing.
- Tested GA4 + AdSense integration.
- Tested Consent Mode.
- Tested Ads module.
- Tested KMW.
from site-kit-wp.
QA Verified ✅
- Smoke tested.
- Verified the changes I’ve been involved with.
- Tested Consent Mode.
- Tested Ads module.
- Tested KMW.
- Performed some ad-hoc testing.
LGTM 👍
from site-kit-wp.
QA Update ✅
- Ran QA check list.
- Verified site kit setup.
- Verified site kit setup with analytics.
- Verified all modules set up.
- Verified data on site with zero and live data.
- Verified main and entity dashboard.
- Verified Ads module setup and migration.
- Verified Tag manager setup and edit functionality by another admin.
- Verified dashboard sharing and KM functionality.
- Verified scenarios related to view only dashboard and another admin.
from site-kit-wp.
QA ✅
- Tested all issues I was involved with.
- Smoke tested as per the release checklist.
- Additional testing of Ads module, Key Metrics and Dashboard Sharing.
from site-kit-wp.
Related Issues (20)
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.` HOT 2
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
- Extract the audience utility logic from `Analytics_4` to a new class.
- Fix glitches in the Audience Segmentation Setup CTA Banner
- "Looks like your site is not allowed access to Google account data" error, despite no changes made HOT 2
- PAX application not loading correctly on the Ads setup screen. HOT 1
- Column Titles Overlapping in 'Top Content Over the Last X Days' Widget on Narrow Viewports.
- Release 1.135.0
- RRM publications list not filtering correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.