Comments (2)
techanvil
commented on August 29, 2024
IB ✅
from site-kit-wp.
kelvinballoo
commented on August 29, 2024
QA Update ✅
This is verified good.
- Just a note that in the ticket description the image having the red arrow towards to left is a bit misleading and should be ignored.
- In the end, the text 'Powered by Site Kit' should be moved to the right, which is what we've implemented.
- Tested on Mac OS (Chrome, Safari and Firefox) and Windows 11 (Edge)
- Verified on Tablet breakpoint (iPad Air)
- Verified on Mobile breakpoint (iPhone SE) even though there is nothing to verify there since the Powered by Site kit doesn't show on mobile
Moving this to Approval.
from site-kit-wp.
Related Issues (20)
- Implement RRM disconnection confirmation modal HOT 8
- Implement RRM setup CTA widget HOT 12
- Add GA tracking for RRM
- Implement RRM `getServiceURL()` selector HOT 7
- Update PAX integrator HOT 2
- Update button font-weight to match design system
- Blank audience tile title when changing GA property HOT 1
- Distance between New badge and text should be 14px instead of 6px. HOT 1
- Margin on top of text of the Change groups CTA should be 32px and not 24px.
- Adjust the CTA and "New" badge positions for widget areas on mobile and tablet viewports. HOT 10
- Release 1.129.0 HOT 7
- Use git lfs for reference images
- Console error: Cannot read properties of undefined (reading 'hasClass')
- Scroll to the Audiences Widget Area from the Setup Success Notice HOT 2
- Scroll to the Audience Segmentation Settings section when navigating there from links on the dashboard HOT 1
- Only render the Audience Segmentation Setup CTA when Analytics is connected HOT 2
- Clear the "temporarily hidden" state for an audience when it's removed from the audience selection HOT 6
- Revise Audience Segmentation component names/locations for consistency HOT 2
- Use the `useInViewSelect()` hook where applicable in the Audience Segmentation feature HOT 6
- Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.