Comments (3)
Hi @kelvinballoo, I'm unable to reproduce any of the issues reported:
The grey background has 2 types of grey but based on Figma, it's supposed to be only one.
The grey background appears consistent and uses only one shade of grey as specified in the Figma design. Please refer to the screenshot below for verification.
There is no rounded border. It should be 8px radius.
The border-radius
in the Figma design is not explicitly specified as 8px
. Upon inspection with a Figma plugin, it is 4px
, which matches our current implementation. Please refer to the screenshot below for clarification.
The font family and size is not right. Based on figma it should be 'Google Sans Text' and 12.
The font-family
is set to Google Sans Text
, and the font-size
is 12px
, as indicated in the Figma design. Please refer to the screenshot below for confirmation.
It’s possible that these discrepancies are due to an older version of WordPress. A similar issue was encountered in #8663. Please ensure you are testing with the latest stable version of WordPress.
Thanks!
cc: @ivonac4
from site-kit-wp.
Thanks @hussain-t .
Yes you are right, this issue is similar to #8663 where it happens on old versions of WordPress 5.6.13.
Since it's an old version, it does not make sense to fix it.
According to WordPress stats only 0.9% of WordPress users are on 5.6.
from site-kit-wp.
Thanks for confirming, @kelvinballoo. Closing this issue based on the above discussion.
from site-kit-wp.
Related Issues (20)
- Implement RRM disconnection confirmation modal
- Implement RRM banner notification
- Add GA tracking for RRM
- Implement RRM `getServiceURL()` selector
- Update PAX integrator HOT 2
- Update button font-weight to match design system
- Blank audience tile title when changing GA property HOT 1
- Distance between New badge and text should be 14px instead of 6px.
- Margin on top of text of the Change groups CTA should be 32px and not 24px.
- The 'Change groups' CTA should appear below the widget area on mobile and tablet viewports up to 783px HOT 4
- Release 1.129.0 HOT 5
- Use git lfs for reference images
- Console error: Cannot read properties of undefined (reading 'hasClass')
- Scroll to the Audiences Widget Area from the Setup Success Notice
- Scroll to the Audience Segmentation Settings section when navigating there from links on the dashboard
- Only render the Audience Segmentation Setup CTA when Analytics is connected
- Clear the "temporarily hidden" state for an audience when it's removed from the audience selection
- Revise Audience Segmentation component names/locations for consistency
- Use the `useInViewSelect()` hook where applicable in the Audience Segmentation feature
- Syncing audiences and custom dimensions in parallel can result in the cached audiences not being persisted
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.