Comments (8)
AC ✅
Moving to IB
from site-kit-wp.
- Toggle will handle saving the settings to the
CORE_SITE
store independently, so the focus of this issue is placing the rendered component in right place as per design and adjusting the wrapper spacing . Styling can be applied inassets/sass/components/ads/_googlesitekit-ads-settings.scss
@zutigrm this line is not correct anymore. We don't need to mention anything about saving because there are no action items for it in this task, it will be handled in another one. Let's remove it to not confuse anyone who will work on it.
from site-kit-wp.
@eugene-manuilov Thanks, IB updated
from site-kit-wp.
Thanks, @zutigrm. IB ✔️
from site-kit-wp.
QA Update ❌
- Tested on dev environment.
- Verified Ads module edit settings view for non PAX manner and PAX manner.
- Verified that toggling the value and saving persists the value on the next page load/reload.
Issue
If the user does not click the "Save" button after changing the toggle value, the toggle value is still getting updated under the settings view. Upon reloading the page, the toggle value reverts to its original status.
Expected Behavior: If the user does not click the "Save" button, the toggle value should not change under the edit view.
Steps to Reproduce:
- Disable/Enable the toggle button.
- Click on the "Cancel" button.
- Notice that the toggle value updates as per the selection in step 1.
- Reload the page.
- Observe that the toggle value reverts to the value before step 1 because the "Save" button was not clicked.
Recording.1042.mp4
Pass Cases
from site-kit-wp.
@mohitwp This has been fixed in #8821 , you can confirm the fix there once it lands in QA
from site-kit-wp.
QA Update
Blocked due to #8821.
from site-kit-wp.
QA Update ✅
- Tested on dev environment.
- Verified Ads module edit settings view for non PAX manner and PAX manner.
- Verified that toggling the value and saving persists the value on the next page load/reload.
- Issue reported above is resolve under #8821.
from site-kit-wp.
Related Issues (20)
- Implement Internal Measurement/Tracking Following ACR KMW Updates
- Enhance compatibility with Docker locally for E2E
- Refactor the `ZeroDataNotification` to use the new lighter `Notification` component. HOT 5
- Release 1.134.0 HOT 4
- Add "Edit in Reader Revenue Manager" link for the RRM module
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.` HOT 2
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.