Coder Social home page Coder Social logo

Comments (4)

10upsimon avatar 10upsimon commented on August 29, 2024

AC ✅ Moving to IB

from site-kit-wp.

eugene-manuilov avatar eugene-manuilov commented on August 29, 2024

IB ✔️

from site-kit-wp.

mohitwp avatar mohitwp commented on August 29, 2024

QA Update ✅

  • Tested on dev environment.
  • Verified when conversionInfra feature flag is disabled.
  • Verified when conversionInfra feature flag is enabled.
  • Verified calls response are as per QAB.

When 'ConversionInfra' feature flag is not enabled.

image

await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
The result should be the default false enabled state: {enabled: false}

image

await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: true } } );
This should update the enabled setting to be true

image

Get the value again using await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
It should be {enabled: true}

image

Validate that a non boolean value can not be set: await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: 'foo' } } );
Should result in an error with a 400 bad request status

image

Set the boolean value using integers: await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: 0 } } );

image

Call the value again using await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
It should again be false as 0 is the boolean equivalent: {enabled: false}

image

Perform the same using 1: await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: 1 } } );

image

Call the value again using await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
It should again be true as 1 is the boolean equivalent: {enabled: true}

image

from site-kit-wp.

aaemnnosttv avatar aaemnnosttv commented on August 29, 2024

@10upsimon @tofumatt I left a comment on the PR with a question about the capabilities chosen here which seem off. See https://github.com/google/site-kit-wp/pull/8692/files#r1605582663

Closing this out as working, but let's follow up with an update if needed.

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.