Comments (4)
AC ✅ Moving to IB
from site-kit-wp.
IB ✔️
from site-kit-wp.
QA Update ✅
- Tested on dev environment.
- Verified when
conversionInfra
feature flag is disabled. - Verified when
conversionInfra
feature flag is enabled. - Verified calls response are as per QAB.
When 'ConversionInfra' feature flag is not enabled.
await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
The result should be the default false enabled state: {enabled: false}
await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: true } } );
This should update the enabled setting to be true
Get the value again using await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
It should be {enabled: true}
Validate that a non boolean value can not be set: await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: 'foo' } } );
Should result in an error with a 400 bad request status
Set the boolean value using integers: await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: 0 } } );
Call the value again using await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
It should again be false as 0 is the boolean equivalent: {enabled: false}
Perform the same using 1: await googlesitekit.api.set( 'core', 'site', 'conversion-tracking', { settings: { enabled: 1 } } );
Call the value again using await googlesitekit.api.get( 'core', 'site', 'conversion-tracking' );
It should again be true as 1 is the boolean equivalent: {enabled: true}
from site-kit-wp.
@10upsimon @tofumatt I left a comment on the PR with a question about the capabilities chosen here which seem off. See https://github.com/google/site-kit-wp/pull/8692/files#r1605582663
Closing this out as working, but let's follow up with an update if needed.
from site-kit-wp.
Related Issues (20)
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.` HOT 2
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
- Extract the audience utility logic from `Analytics_4` to a new class.
- Fix glitches in the Audience Segmentation Setup CTA Banner
- "Looks like your site is not allowed access to Google account data" error, despite no changes made HOT 2
- PAX application not loading correctly on the Ads setup screen. HOT 1
- Column Titles Overlapping in 'Top Content Over the Last X Days' Widget on Narrow Viewports.
- Release 1.135.0
- RRM publications list not filtering correctly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.