Comments (10)
As mentioned in Slack: let's keep that message in there 😄
from site-kit-wp.
Thank you folks! I've opened a follow-up PR #8028 that restores this text. Thanks!
from site-kit-wp.
Noting that the longer-term goal would be to implement #7986 to block users from proceeding with setup in this case. This would be a shorter-term solution prompting them to get help in order to proceed.
from site-kit-wp.
Per discussion with @aaemnnosttv, this should be a small change to update this specific case, and we'll need to determine if this error ID needs to be added to the related sheet. Moving to AC.
from site-kit-wp.
IB ✅
@eugene-manuilov, tagging you as a heads up re. the IB point about this needing a Service Engineering task.
Update: Looks like this is already covered on Slack.
from site-kit-wp.
QA Update: ❌
@nfmohit I have two observations that I'd like to raise.
- I see the message highlighted in the initial ticket description on the latest release. When I switch to the develop branch, though, a different message appears.
Looks like your site is having a technical issue with requesting data from Google services
The AC doesn't refer to a change in the message so wanted to check.
2. The URL on the "Get Help" link points to the URL in the AC, but when I click the link, I am redirected to the support forum. Is that expected right now? This issue is expected until the updates are in production. I have created an Asana task to check this as part of my post-release testing.
from site-kit-wp.
Hi @wpdarren, thank you for sharing your observations.
- I see the message highlighted in the initial ticket description on the latest release. When I switch to the develop branch, though, a different message appears.
Looks like your site is having a technical issue with requesting data from Google services
The AC doesn't refer to a change in the message so wanted to check.
The part that I removed ("To get more help, ask a question on our support forum and include the text of the original error message: google_api_connection_fail") is already covered in the linked documentation, so I don't think there's much point in including that again in the message. Also, this follows the pattern of other similar error messages in this context which also have a "Get help" link.
@tofumatt As you had authored the ACs here, just to confirm, do you think it is still necessary to include this part in the error message?
Thank you!
from site-kit-wp.
QA Update: ❌
@nfmohit I apologize in advance for being picky, but as QA, it is what I do. 😄
Could we have the google_api_connection_fail
text on the same line above, next to message:
It just looks a bit odd underneath.
Also, I noticed a difference in the URLs.
On the AC. https://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail
On my test site: https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
It's worth noting the QAB states https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
Have I missed something here?
from site-kit-wp.
Hi @wpdarren.
Thank you for sharing your observation.
Could we have the
google_api_connection_fail
text on the same line above, next tomessage:
It just looks a bit odd underneath.
I understand, however, this is the pre-existing structure of error messages like these. This issue doesn't change the structure of the message but adds to it. Here is a similar error message:
For consistency, do you think it would be nicer to change all of them in a different issue?
Also, I noticed a difference in the URLs.
On the AC.
https://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail
On my test site:https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
It's worth noting the QAB stateshttps://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
https://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail
is the actual URL for the documentation.
https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
is our proxy URL which will ultimately redirect the user to the actual documentation once the updates in the service side are pushed to production (see point #2 of this comment).
Please let me know what you think, thanks!
from site-kit-wp.
QA Update: ✅
Thanks, @nfmohit, that all makes sense.
For consistency, do you think it would be nicer to change all of them in a different issue?
Yes, I will create a new ticket for all of these messages.
Your example has bad formatting, so we should look to tidy it up, but it is a low priority in the scheme of things!
Verified:
- The error message described in the issue appears.
- The "Get help" link points to this URL:
https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
from site-kit-wp.
Related Issues (20)
- Sort Storybook menu items HOT 1
- Enhance feature activation for BC
- Revert the Fix For VRT failures HOT 1
- Google Site Kit plugin fails to load data on my WordPress website HOT 1
- Fix issue where VRT test fails in CI when launching Chromium HOT 1
- Ensure cached audiences are resynced when the No Audiences Banner is shown
- Enhancement for subtle notifications
- Enhancement on CTA order on mobile for subtle notifications
- Creation of `Top traffic source driving leads` ACR KMW HOT 1
- Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing
- Storybook error during build: `Error: Source and destination must not be the same.` HOT 2
- Refactor the `AudienceTiles` component to make it easier to read
- Gathering data notification - Loader not appearing on 'See other services' CTA click
- 'a.getTime is not a function' error on dashboard
- Zero Data Notification Not Appearing on First Load in New Tab/Window; Requires Page Refresh
- Extract the audience utility logic from `Analytics_4` to a new class.
- Fix glitches in the Audience Segmentation Setup CTA Banner
- "Looks like your site is not allowed access to Google account data" error, despite no changes made HOT 2
- PAX application not loading correctly on the Ads setup screen. HOT 1
- Column Titles Overlapping in 'Top Content Over the Last X Days' Widget on Narrow Viewports.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from site-kit-wp.