Coder Social home page Coder Social logo

Add a "Get Help" link or link within the existing text for users who encounter the google_api_connection_fail error about site-kit-wp HOT 10 CLOSED

jamesozzie avatar jamesozzie commented on August 29, 2024
Add a "Get Help" link or link within the existing text for users who encounter the google_api_connection_fail error

from site-kit-wp.

Comments (10)

tofumatt avatar tofumatt commented on August 29, 2024 1

As mentioned in Slack: let's keep that message in there 😄

from site-kit-wp.

nfmohit avatar nfmohit commented on August 29, 2024 1

Thank you folks! I've opened a follow-up PR #8028 that restores this text. Thanks!

from site-kit-wp.

mxbclang avatar mxbclang commented on August 29, 2024

Noting that the longer-term goal would be to implement #7986 to block users from proceeding with setup in this case. This would be a shorter-term solution prompting them to get help in order to proceed.

from site-kit-wp.

mxbclang avatar mxbclang commented on August 29, 2024

Per discussion with @aaemnnosttv, this should be a small change to update this specific case, and we'll need to determine if this error ID needs to be added to the related sheet. Moving to AC.

from site-kit-wp.

techanvil avatar techanvil commented on August 29, 2024

IB ✅

@eugene-manuilov, tagging you as a heads up re. the IB point about this needing a Service Engineering task.

Update: Looks like this is already covered on Slack.

from site-kit-wp.

wpdarren avatar wpdarren commented on August 29, 2024

QA Update: ❌

@nfmohit I have two observations that I'd like to raise.

  1. I see the message highlighted in the initial ticket description on the latest release. When I switch to the develop branch, though, a different message appears. Looks like your site is having a technical issue with requesting data from Google services The AC doesn't refer to a change in the message so wanted to check.

image

2. The URL on the "Get Help" link points to the URL in the AC, but when I click the link, I am redirected to the support forum. Is that expected right now? This issue is expected until the updates are in production. I have created an Asana task to check this as part of my post-release testing.

from site-kit-wp.

nfmohit avatar nfmohit commented on August 29, 2024

Hi @wpdarren, thank you for sharing your observations.

  1. I see the message highlighted in the initial ticket description on the latest release. When I switch to the develop branch, though, a different message appears. Looks like your site is having a technical issue with requesting data from Google services The AC doesn't refer to a change in the message so wanted to check.

The part that I removed ("To get more help, ask a question on our support forum and include the text of the original error message: google_api_connection_fail") is already covered in the linked documentation, so I don't think there's much point in including that again in the message. Also, this follows the pattern of other similar error messages in this context which also have a "Get help" link.

@tofumatt As you had authored the ACs here, just to confirm, do you think it is still necessary to include this part in the error message?

Thank you!

from site-kit-wp.

wpdarren avatar wpdarren commented on August 29, 2024

QA Update: ❌

@nfmohit I apologize in advance for being picky, but as QA, it is what I do. 😄

Could we have the google_api_connection_fail text on the same line above, next to message:

It just looks a bit odd underneath.

image

Also, I noticed a difference in the URLs.

On the AC. https://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail
On my test site: https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail
It's worth noting the QAB states https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail

Have I missed something here?

from site-kit-wp.

nfmohit avatar nfmohit commented on August 29, 2024

Hi @wpdarren.
Thank you for sharing your observation.

Could we have the google_api_connection_fail text on the same line above, next to message:

It just looks a bit odd underneath.

I understand, however, this is the pre-existing structure of error messages like these. This issue doesn't change the structure of the message but adds to it. Here is a similar error message:

image

For consistency, do you think it would be nicer to change all of them in a different issue?

Also, I noticed a difference in the URLs.

On the AC. https://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail On my test site: https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail It's worth noting the QAB states https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail

https://sitekit.withgoogle.com/documentation/troubleshooting/setup/#google_api_connection_fail is the actual URL for the documentation.

https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail is our proxy URL which will ultimately redirect the user to the actual documentation once the updates in the service side are pushed to production (see point #2 of this comment).

Please let me know what you think, thanks!

from site-kit-wp.

wpdarren avatar wpdarren commented on August 29, 2024

QA Update: ✅

Thanks, @nfmohit, that all makes sense.

For consistency, do you think it would be nicer to change all of them in a different issue?

Yes, I will create a new ticket for all of these messages.

Your example has bad formatting, so we should look to tidy it up, but it is a low priority in the scheme of things!

Verified:

  • The error message described in the issue appears.
  • The "Get help" link points to this URL: https://sitekit.withgoogle.com/support?error_id=google_api_connection_fail

image

from site-kit-wp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.