Create “Top categories by pageviews” key metric widget tile about site-kit-wp

[techanvil]

Thanks @nfmohit! AC ✅

[marrrmarrr]

@jimmymadon since this is a pretty rare corner case, I'd suggest leaving it for the "nice to have" issue we mentioned on Slack the other day.

[jimmymadon]

since this is a pretty rare corner case, I'd suggest leaving it for the "nice to have" issue we mentioned on Slack the other day.

In our AC Sync today, we decided not to worry about duplicate Category Names within different parents, i.e. no new nice to have issues needs to be created for this case as of now. We can create an issue post-launch if we get any support requests and notice this being a common issue.

c.c. @marrrmarrr @techanvil @nfmohit @aaemnnosttv

[nfmohit]

Hi @hussain-t & @aaemnnosttv.

It looks like the merged PR #7708 doesn't pass the tile's report options to the HOC. The tile still works without this, but if just in case the required custom dimension gets removed from the property in any way, the HOC will not catch the problem and will not update the list of available custom dimensions.

What do you think?

[nfmohit]

Hi @hussain-t & @aaemnnosttv.

It looks like the merged PR #7708 doesn't pass the tile's report options to the HOC. The tile still works without this, but if just in case the required custom dimension gets removed from the property in any way, the HOC will not catch the problem and will not update the list of available custom dimensions.

What do you think?

I can confirm that the follow-up PR #7711 addresses this concern. Moved back to QA. Thank you @hussain-t !

[techanvil]

Hey @nfmohit! This is also similar to #6703 and the first part of my comment there applies here too.

That aside, there's a small detail to address here - it looks like the metric tile title should be "Top categories by pageviews", but it's defined in the AC as "Most popular categories by pageviews". Can you please confirm which is correct and update as necessary?

[nfmohit]

Thank you @techanvil!

This is also similar to #6703 and the first part of my comment there applies here too.

Understood. I've updated the ACs to be a little higher-level.

That aside, there's a small detail to address here - it looks like the metric tile title should be "Top categories by pageviews", but it's defined in the AC as "Most popular categories by pageviews". Can you please confirm which is correct and update as necessary?

Excellent catch. Updated. Thank you!

[techanvil]

IB ✅

[jimmymadon]

@marrrmarrr Do we want to cater for the rare edge case where there could be duplicate category names (having different ancestors/parents)? Is there any sense in showing Parent > Child 1 > Child 1.1? Or should we skip this and ensure we link to the appropriate archive pages in the "nice to have" issue that we are creating?

[aaemnnosttv]

Picking this back up to fix something I broke during CR 🤦

[wpdarren]

QA Update: ✅

Verified:

• A new component is created for the Top categories by pageviews key metric widget tile and is displayed within the Key Metrics Widget area if it is selected in the key metrics selection panel.
• The component looks as its Figma mock.
• Its widget slug is kmAnalyticsTopCategories
• The metric tile title is Top categories by pageviews
• Its description tooltip says Categories that your site visitors viewed the most.
• This metric is dependent on the analytics-4 module.
• The component is a table pattern metric tile, with the category name(s) showing up as the first column, and screenPageViews showing up as the second column.
• The metrics & dimensions are available for view-only users.
• Checked the data compared with Analytics and everything matches.

Note: we do have a known issue around the [not set] data appearing in the tile and this will be investigated and discussed.

Screenshot