Comments (10)
It should be unsigned. typo.
from sagetv.
Are you going to submit a change for this Fred?
from sagetv.
Given that it's Qian's regression, I was hoping he would do the submit :^)
from sagetv.
Whatever is fine...I figured you found the bug, so you should get credit
for the commit fix. :-)
Jeff Kardatzke
Sent from my Android
On Nov 20, 2015 3:09 PM, "Keith Fischer" [email protected] wrote:
Given that it's Qian's regression, I was hoping he would do the submit :^)
—
Reply to this email directly or view it on GitHub
#55 (comment).
from sagetv.
I come from a culture of "if you break it, you get to fix it". I don't feel a big need to rack up brownie points and also didn't want to step on anybody's turf. Will wait for a response from Qian.
from sagetv.
@JustFred51 Thank you for finding the issue. I've manually edited my cloned repo and recompiled with VS2015, and FWIW I can confirm this fixes the problem I was having with no audio on mpeg videos.
Thanks again,
Carey
from sagetv.
@Hiltronix Thanks for the feedback.
I'm pretty sure that the change between unsigned/signed introduced a problem with how sign-extension affects the comparisons.
Were you able to turn on any debug messages that gave a clue about the failure? I didn't notice anything in Native.log. Still learning what what tools are available to debug the native code. I didn't find Graphedt or GraphStudio to be particularly useful, but I'm not a multimedia guy.
from sagetv.
@JustFred51 No, I'm in a similar boat to you, and to be honest I'm new to debugging video issues like this. I initially figured out which filter file it was mainly through trial and error, swapping out the new for old and narrowing it down, checking playback. Since then I've started on my learning curve on this topic, using GraphStudio, turning on Sage debug and watching the "DShowGraphFilters" values in "sagetv_0.txt" and "sagetvclient_0.txt", to see what filters Sage is using.
Learning more about this has helped me select codecs for improving how Sage plays back videos other than .ts and .mpg. My biggest issue with SageTV has always been the playback of file formats other than it's own recordings. It's been such a time waster over the years (for me at least) playing with codecs, splitters, etc. that are compatible with Sage, and having to learn the ins and outs of tweaking everything to have it be my main video player and not just the recorder and playback for it's own recordings. My hope for SageTV OS is that some devs with knowledge on this topic will someday make the easy playback capability of all video types as idiot proof as Kodi/XBMC , MPC or VLC. Sorry for the rant, it's not completely off topic, it's Sage video related, but probably not the correct forum. :)
from sagetv.
I submitted the fix. Thanks @JustFred51 https://github.com/JustFred51
Qian
On Fri, Nov 20, 2015 at 3:08 PM, Keith Fischer [email protected]
wrote:
Given that it's Qian's regression, I was hoping he would do the submit :^)
—
Reply to this email directly or view it on GitHub
#55 (comment).
from sagetv.
Great! Thanks.
from sagetv.
Related Issues (20)
- Change channel scanning upper limit for US and Canada HOT 1
- double zip codes HOT 1
- How to fix tuners not working and get rid of all the accumulated unused channels HOT 1
- Watched icon/flag behavior HOT 3
- Please open a security advisory HOT 4
- Travis CI integration no longer working HOT 6
- Playback of file crashes when loading external SRT file HOT 3
- Difference in Sage.jar between Windows and Linux builds HOT 6
- How to use EPGDBPublic2.java HOT 1
- Fix existing tuner input type to display all options and configure, it currently does not HOT 4
- Scheduled Direct duplicate program requests HOT 13
- SageTV is making too many celebrity requests on Schedules Direct HOT 3
- Security Policy violation Binary Artifacts HOT 2
- Extract Media Description from video file
- Import folders or media with extenced ascii characters are ignored
- LinuxMPlayerPlugin.java: video out parameter? HOT 1
- Guide data/Manual Recording issue with padding less than show length HOT 10
- 9.2.6.976 - Missing show airings in Future/Additional Airings
- Feature Request web based channel tuning HOT 11
- SageTV Commerical Skip Plugin Not Working on Some Devices But Does On Others HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sagetv.