Comments (1)
There are a few unrelated pieces of software at play here. I'm probably going to be overly verbose just to make sure we're on the same page :)
AGP is responsible for creating the prefab packages that get included in AARs. This is step 3 in your list. If the package is being generated incorrectly, the bug is in AGP.
Prefab is the command line tool that consumes the prefab/
subdirectory of an AAR (or from whatever source, the AAR is just the most common distribution method) and generates build scripts (in this case CMake package configs) that can be imported by your build system. This is step 4 in your list. If there's data in the prefab metadata that isn't making it into the build scripts, that's a prefab bug. If there's data that cannot be described by prefab, that's a prefab feature request.
I think there are two things here. The first of which is a bug where AGP is not aware of the name difference, so there is a bug in AGP there. That needs to be filed against AGP rather than here; prefab is doing the right thing, it's just being fed a broken package.
The second thing that might be here is a feature request for prefab to support build variants like debug/release explicitly. I don't know if this is feasible because while debug/release are fairly widely accepted build variants, many systems include others (CMake has things like MinSizeRelease
and RelWithDebInfo
), and others like AGP allow arbitrary addition of more build variants on a per module basis. I think a better way to handle this would be to keep the gradleisms in gradle: build variants of the AAR for each build flavor and let your dependencies vary by build flavor while keeping the imported package/module names in cmake the same.
lmk if any of that doesn't match with your understanding. If it all seems right, file the AGP bug and paste the link here so I can CC myself :)
from prefab.
Related Issues (20)
- [FR] explicit ABI split for sanitized libraries?
- not compatible library issue HOT 4
- Use prefab from build.gradle to publish a precompiled library. HOT 1
- [BUG] Start signing com.google.prefab:cli:2.0.0 artifacts HOT 3
- [BUG] Library not exposing c++ symbols, still enforcing its STL in the abi.json HOT 3
- [FR] Model runtime-only dependencies HOT 9
- [FR] [QUESTION] How to model optional dependencies? HOT 7
- [BUG] prefab should set LINKER_LANGUAGE property for static libraries HOT 3
- use enable_language as needed in cmake outputs? HOT 3
- [BUG] when used prefab, the module aar will have duplicate so. The one in the jni/lib, A another one is in the prefab dir. HOT 2
- [FR] export_preprocessor_defs and export_includes HOT 9
- [FR] Support app module denpends on another module which all have C/C++ code. HOT 2
- [FR] Request ability to build prefab on apple silicon: fail to get a suitable JDK HOT 1
- [FR] Add support for riscv64 HOT 1
- [FR] add better handling of whole-archive style libraries HOT 1
- [BUG] ndkports: Pull Request: Create parent directory before trying to extract file from dependency aar HOT 2
- [FR] Please revive the project HOT 1
- [BUG] CMake packages and imported targets naming incompatible with upstream HOT 1
- [FR] Support c++ modules HOT 5
- [FR] Bundle sources with prefab archive HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prefab.