Coder Social home page Coder Social logo

Comments (1)

DanAlbert avatar DanAlbert commented on July 3, 2024

There are a few unrelated pieces of software at play here. I'm probably going to be overly verbose just to make sure we're on the same page :)

AGP is responsible for creating the prefab packages that get included in AARs. This is step 3 in your list. If the package is being generated incorrectly, the bug is in AGP.

Prefab is the command line tool that consumes the prefab/ subdirectory of an AAR (or from whatever source, the AAR is just the most common distribution method) and generates build scripts (in this case CMake package configs) that can be imported by your build system. This is step 4 in your list. If there's data in the prefab metadata that isn't making it into the build scripts, that's a prefab bug. If there's data that cannot be described by prefab, that's a prefab feature request.

I think there are two things here. The first of which is a bug where AGP is not aware of the name difference, so there is a bug in AGP there. That needs to be filed against AGP rather than here; prefab is doing the right thing, it's just being fed a broken package.

The second thing that might be here is a feature request for prefab to support build variants like debug/release explicitly. I don't know if this is feasible because while debug/release are fairly widely accepted build variants, many systems include others (CMake has things like MinSizeRelease and RelWithDebInfo), and others like AGP allow arbitrary addition of more build variants on a per module basis. I think a better way to handle this would be to keep the gradleisms in gradle: build variants of the AAR for each build flavor and let your dependencies vary by build flavor while keeping the imported package/module names in cmake the same.

lmk if any of that doesn't match with your understanding. If it all seems right, file the AGP bug and paste the link here so I can CC myself :)

from prefab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.