tagfocus needs better support for picking which tag to focus on about pprof

[aalexand]

One simple way to address this is to make show filter for tags handled before the tag focus handling (here)[https://github.com/google/pprof/blob/805912e7989642128fbdcec1fc80e04396e6f709/internal/driver/driver_focus.go#L49]

Then it would be possible to do something like -tagshow=request -tagfocus=256kb:512kb and it would do what you want I think, except that it wouldn't show you other tags.

[ahh]

That would be an OK stopgap, but I generally want to see all the tags, I just want to filter based on particulars.

[aalexand]

Maybe we should do the simple thing first then.

For the syntax you proposed, I think I'd prefer the desired tag name to be specified exactly, not a substring or regexp match. That would allow recognizing whether the same tag is requested and handle things like -tagfocus=mytag=foo -tagfocus=mytag=bar -tagfocus=myothertag=baz naturally as (mytag == "foo" || mytag == "bar") || myothertag == "baz". From the tag names that I saw so far, I can't see much advantage of being able to regexp match tag names.

[nolanmar511]

This is not a solution, but if you really want to try out this functionality right now, you could do something like -tagfocus=262144request:524288request, which would allow other tags to be shown.

This is definitely hack-y and takes advantage of an odd quirk in which tag names are used as units.

[ahh]

Regexp was just a half-assed suggestion; exact match I'm totally fine with. Margaret's solution is in fact a workaround :), but also problematic (I'd much prefer some way to make "request=512kb" work, it's much more usable.)

…

On Thu, Jul 27, 2017 at 11:01 AM Margaret Nolan ***@***.***> wrote: This is not a solution, but if you really want to try out this functionality right now, you could do something like -tagfocus=262144request:524288request, which would allow other tags to be shown. This is definitely hack-y and takes advantage of the problems an odd quirk in which tag names are used as units. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#178 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAPHrqxMmNOrciRsOo1yvGyI7FxQ_vypks5sSNB9gaJpZM4Ok2hU> .

[aalexand]

@nolanmar511 This is fixed with #183?

[nolanmar511]

Yes -- we did fix this with #183