Coder Social home page Coder Social logo

Comments (10)

ericwooley avatar ericwooley commented on June 25, 2024 2

Should this not have 20 as well now?

from pprof-nodejs.

franleplant avatar franleplant commented on June 25, 2024 2

would love to see support for node@20 20

from pprof-nodejs.

nolanmar511 avatar nolanmar511 commented on June 25, 2024 1

Might be possible to switch to using Node.js's inspector & drop the native portion of this library once LTS for Node 12 has ended.

from pprof-nodejs.

pietrodn avatar pietrodn commented on June 25, 2024 1

Sorry, I realized that somehow the binary I had in node_modules was built against the wrong Node runtime. A reinstall did the trick.

from pprof-nodejs.

amchiclet avatar amchiclet commented on June 25, 2024

Revisiting this issue now. Updating the title so it matches the current releases of node.

The plan is to update the tests for node 17 and 18 and drop tests for node 10 and 15.

Would also like to note that since we use source-map, the tests for node 18 will fail until the upstream issue is officially fixed.

A workaround is to use the 0.8.0-beta.0 version of source-map.

from pprof-nodejs.

nolanmar511 avatar nolanmar511 commented on June 25, 2024

node-pre-gyp does not currently have maintainers (mapbox/node-pre-gyp#657) and does not support building node 18 binaries on a machine using another version of node (mapbox/node-pre-gyp#647).

Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18.

from pprof-nodejs.

aabmass avatar aabmass commented on June 25, 2024

Should also update the docs here https://cloud.google.com/profiler/docs/profiling-nodejs

from pprof-nodejs.

pietrodn avatar pietrodn commented on June 25, 2024

Would it be possible to cut a release to have Node 18 support on the latest stable version? Thanks.

from pprof-nodejs.

aabmass avatar aabmass commented on June 25, 2024

This library works fine on node 18 already. The only issue is we can't supply pre-built binaries. Are you seeing a specific issue @pietrodn ?

from pprof-nodejs.

aabmass avatar aabmass commented on June 25, 2024

It should work fine in node 20 already. Please see #273 (comment), for more info.

from pprof-nodejs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.