Comments (10)
Should this not have 20 as well now?
from pprof-nodejs.
would love to see support for node@20 20
from pprof-nodejs.
Might be possible to switch to using Node.js's inspector & drop the native portion of this library once LTS for Node 12 has ended.
from pprof-nodejs.
Sorry, I realized that somehow the binary I had in node_modules
was built against the wrong Node runtime. A reinstall did the trick.
from pprof-nodejs.
Revisiting this issue now. Updating the title so it matches the current releases of node.
The plan is to update the tests for node 17 and 18 and drop tests for node 10 and 15.
Would also like to note that since we use source-map
, the tests for node 18 will fail until the upstream issue is officially fixed.
A workaround is to use the 0.8.0-beta.0
version of source-map
.
from pprof-nodejs.
node-pre-gyp
does not currently have maintainers (mapbox/node-pre-gyp#657) and does not support building node 18 binaries on a machine using another version of node (mapbox/node-pre-gyp#647).
Given this, the approach for generating pre-built binaries will need to change to build binaries for Node 18.
from pprof-nodejs.
Should also update the docs here https://cloud.google.com/profiler/docs/profiling-nodejs
from pprof-nodejs.
Would it be possible to cut a release to have Node 18 support on the latest stable version? Thanks.
from pprof-nodejs.
This library works fine on node 18 already. The only issue is we can't supply pre-built binaries. Are you seeing a specific issue @pietrodn ?
from pprof-nodejs.
It should work fine in node 20 already. Please see #273 (comment), for more info.
from pprof-nodejs.
Related Issues (20)
- Cannot npm install [email protected] with node 12.16.1 HOT 1
- Action Required: Fix Renovate Configuration
- Error installing pprof with nodejs v14 HOT 2
- Add support for Node 16
- Dependency Dashboard
- Receiving a 404 error on Apple M1
- Receiving a 404 error on Apple M1 HOT 2
- Remove feature "requiring from the command line"
- CVE-2023-36665 vunerablity in protobufjs >= 6.10.0, < 7.2.4 HOT 1
- Module did not self-register: Worker Threads HOT 2
- [node 20] Compilation error on nan HOT 9
- System test failing for Node 21 HOT 1
- Publish pre-built binaries for native components for Windows
- Stop suppressing warnings with -Wno-cast-function-type HOT 1
- Support Node 12 HOT 2
- Fix compilation warnings with Node 12. HOT 1
- How should profiling interact with worker-threads? HOT 3
- Expose a profile to pprof CLI HOT 1
- Doesn't compile on windows HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pprof-nodejs.