Comments (6)
I don't think I'll have time tomorrow (and this weekend I finally need to do the tax returns I've procrastinated on), but I should be able to get to this early next week.
from personfinder.
Thanks! It is not urgent, so take your time. Let me know if you are busy and have no time working on this. I will probably have some bandwidth, so I may be able to take this kind of small fixes.
from personfinder.
This is the mapping from URL patterns to their handlers:
https://github.com/google/personfinder/blob/master/app/app.yaml
When the URL is mapped to script: wsgi.application
, it is handled by Django. When it is mapped to script: main.py
(i.e., when it doesn't match other patterns), it is handled by app/main.py, our traditional main handler.
URL "/global" should be alias of /global/home.html (and also "/"), and /global/home.html is handled by Django but /global doesn't look so. This looks like an issue.
You also need to let Django handle /global properly. This looks configured here:
https://github.com/google/personfinder/blob/master/app/urls.py
I'm not familiar yet about how Django routing is configured though.
from personfinder.
@gimite Thank you for sharing the findings. Very helpful to catch up.
All the URL patterns (/
, /global/home
, /global
) should be handled by GlobalIndexView
, but /global
does not seem to be listed and configured in urls.py
.
At a glance, it would be quick to fix it by adding just a few lines in the urls.py
.
Not very critical but a remaining concern could be at which version it stopped working and what kind of changes were made then. I will try to chase it just in case.
from personfinder.
Thanks! It was broken a while ago, so we don't really need to know when it got broken :) You can investigate it if you are curious though. All traffic used to be served from main.py, so it sounds likely that it was broken when we migrate it to Django.
from personfinder.
Noted. Then I will try to fix it anyway.
from personfinder.
Related Issues (20)
- Dead link from "full_name" fields in "Review notes" page
- Our Python 2.7.12 tests can't run
- Python 2.07
- tar xvfz does not work to extract PIL 1.1.7 in GettingStarted HOT 2
- Repositories do not appear in the left-side navigation menu on localhost:8080
- Archive file for python 2.7.12 is gone in storage.googleapis.com/travis-ci-language-archives/ HOT 1
- flake8 is missing and thus no unit tests run HOT 1
- Skip and optimize "Updating translations" in tools/server_tests HOT 3
- Packages are missing in GettingStarted and server tests fail HOT 4
- Images in "Howto" page are 404 HOT 3
- appcfg is deprecated: Correct command in GettingStarted Step 6 HOT 17
- Incorrect arguments are passed in docker/gae-run-app.sh HOT 1
- Require reCAPTCHA to create person records
- Show a link to Google Maps for the user-provided location in notes in the new React UI
- Import/generate translations for the new React UI
- Redirect from the old UI URL to the new React UI URL if needed
- Replace the feedback link with an email address HOT 1
- Turkey 2023/02/06 HOT 2
- Person Finder has no visibility on search engine results
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from personfinder.