Coder Social home page Coder Social logo

Comments (6)

nworden avatar nworden commented on May 26, 2024

I don't think I'll have time tomorrow (and this weekend I finally need to do the tax returns I've procrastinated on), but I should be able to get to this early next week.

from personfinder.

gimite avatar gimite commented on May 26, 2024

Thanks! It is not urgent, so take your time. Let me know if you are busy and have no time working on this. I will probably have some bandwidth, so I may be able to take this kind of small fixes.

from personfinder.

gimite avatar gimite commented on May 26, 2024

This is the mapping from URL patterns to their handlers:
https://github.com/google/personfinder/blob/master/app/app.yaml

When the URL is mapped to script: wsgi.application, it is handled by Django. When it is mapped to script: main.py (i.e., when it doesn't match other patterns), it is handled by app/main.py, our traditional main handler.

URL "/global" should be alias of /global/home.html (and also "/"), and /global/home.html is handled by Django but /global doesn't look so. This looks like an issue.

You also need to let Django handle /global properly. This looks configured here:
https://github.com/google/personfinder/blob/master/app/urls.py
I'm not familiar yet about how Django routing is configured though.

from personfinder.

ryosuketc avatar ryosuketc commented on May 26, 2024

@gimite Thank you for sharing the findings. Very helpful to catch up.

All the URL patterns (/, /global/home, /global) should be handled by GlobalIndexView, but /global does not seem to be listed and configured in urls.py.
At a glance, it would be quick to fix it by adding just a few lines in the urls.py.

Not very critical but a remaining concern could be at which version it stopped working and what kind of changes were made then. I will try to chase it just in case.

from personfinder.

gimite avatar gimite commented on May 26, 2024

Thanks! It was broken a while ago, so we don't really need to know when it got broken :) You can investigate it if you are curious though. All traffic used to be served from main.py, so it sounds likely that it was broken when we migrate it to Django.

from personfinder.

ryosuketc avatar ryosuketc commented on May 26, 2024

Noted. Then I will try to fix it anyway.

from personfinder.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.