web_gui build is broken about openhtf

[lalten]

It looks like running webpack directly works because the failing uglify js is only called when isProd is true, which is not the case when invoking directly instead of via npm run build.

openhtf/openhtf/output/web_gui/webpack.config.js

Line 19 in e724173

var isProd = ENV === 'build';

[lalten]

You can replace Uglify (which is a dead and unmaintained project anyways) with Terser, specifically the legacy webpack plugin (without upgrading webpack).

❯ npm install terser-webpack-plugin-legacy --save-dev
❯ npm install webpack@3 --save-dev

diff --git a/openhtf/output/web_gui/webpack.config.js b/openhtf/output/web_gui/webpack.config.js
index 4bcdec1..a3a9b9a 100644
--- a/openhtf/output/web_gui/webpack.config.js
+++ b/openhtf/output/web_gui/webpack.config.js
@@ -8,6 +8,7 @@ var autoprefixer = require('autoprefixer');
 var HtmlWebpackPlugin = require('html-webpack-plugin');
 var ExtractTextPlugin = require('extract-text-webpack-plugin');
 var CopyWebpackPlugin = require('copy-webpack-plugin');
+const TerserPlugin = require('terser-webpack-plugin-legacy');
 
 /**
  * Env
@@ -270,7 +271,8 @@ module.exports = function makeWebpackConfig() {
 
       // Reference: http://webpack.github.io/docs/list-of-plugins.html#uglifyjsplugin
       // Minify all javascript, switch loaders to minimizing mode
-      new webpack.optimize.UglifyJsPlugin({sourceMap: true, mangle: { keep_fnames: true }}),
+      new TerserPlugin({sourceMap: true, terserOptions: { keep_fnames: true }}),
+
 
       // Copy assets from the public folder
       // Reference: https://github.com/kevlened/copy-webpack-plugin

At this point, npm run build works again. However, the next problem is that the UI does not load. It crashes on
Uncaught Error: StaticInjectorError[{provide:CompilerFactory, useClass:JitCompilerFactory}]: 'deps' required.

This is something about Angular, but I don't know how to fix this.

[lalten]

OK it turns out if you also revert #1014 and the change in openhtf/output/web_gui/src/app/stations/station/station.component.spec.ts from #1004 the build works again.

[lalten]

I think it would make a lot of sense to add a CI check that ensures npm run build always works.

[glados-verma]

Currently the node version needs to be downgraded to 9 in order to successfully build. #1024 might help with that, I will take a look.